feat: Support UUID data type #14301
Closed
feat: Support UUID data type #14301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I forgot to add a commit when moving to the fork. I will update it! |
Contributor
|
OK, let me know when it's ready for review. |
aandreassa
force-pushed
the
uuid
branch
3 times, most recently
from
5dc29be to
b8fde91
Compare
amanda-tarafa
requested changes
Apr 2, 2025
Contributor
amanda-tarafa
left a comment
amanda-tarafa
left a comment
There was a problem hiding this comment.
@aandreassa Can you get the tests passing so I can do a full review? Thanks!
amanda-tarafa
requested changes
Apr 2, 2025
| internal const string DecimalToPgNumeric = nameof(DecimalToPgNumeric); | ||
| internal const string DateTimeToDate = nameof(DateTimeToDate); | ||
| internal const string DateTimeToTimestamp = nameof(DateTimeToTimestamp); | ||
| internal const string GuidToUuid = nameof(GuidToUuid); |
Contributor
There was a problem hiding this comment.
I don't think we need these options for Guid. The relantionship between the Spanner and CLR type is one to one here.
amanda-tarafa
added
the
do not merge
Contributor
|
Closing in favour of #15369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.