feat: API regeneration: 20260106T080112Z #15359
Conversation
feat: add streaming function call argument API changes docs: A comment for field `name` in message `.google.cloud.aiplatform.v1beta1.FunctionCall` is changed docs: A comment for field `args` in message `.google.cloud.aiplatform.v1beta1.FunctionCall` is changed PiperOrigin-RevId: 852409018 Source-Link: googleapis/googleapis@286c66a
feat: add custom prompt config in the request and return prompt in the response feat: update min_speaker_count and max_speaker_count to be optional docs: Clarify that min_speaker_count and max_speaker_count in SpeakerDiarizationConfig are not currently used docs: Update guidance on how to enable speaker diarization; to enable, set the diarization_config field to an empty SpeakerDiarizationConfig message PiperOrigin-RevId: 852383212 Source-Link: googleapis/googleapis@1a14153
google-cloud-sdk-librarian-dotnet-robot
requested a review
from a team
as a code owner
Summary of ChangesHello @google-cloud-sdk-librarian-dotnet-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents an automated regeneration of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request contains auto-generated API client updates for Google.Cloud.AIPlatform.V1Beta1 and Google.Cloud.Speech.V2. The changes introduce support for streaming function call arguments. The generated code is mostly correct, but I've identified a minor documentation issue in a new property that could cause confusion. My review includes a suggestion to improve its clarity.
| public const int WillContinueFieldNumber = 5; | ||
| private bool willContinue_; | ||
| /// <summary> | ||
| /// Optional. Whether this is the last part of the FunctionCall. |
There was a problem hiding this comment.
The documentation for WillContinue is contradictory. It states that this property indicates if this is the 'last part' of the FunctionCall, but then clarifies that if true, another message is expected to follow. This is confusing for developers. To improve clarity, the documentation should unambiguously state that this property indicates if it's not the last part.
/// Optional. Whether this is not the last part of the FunctionCall.
|
Pull request diff results Diff level: Minor Comparing with previous NuGet package Diff level: Minor Finished comparisons for Google.Cloud.AIPlatform.V1Beta1 Finding changes in Google.Cloud.Speech.V2... Diff level: Minor Comparing with previous NuGet package Diff level: Minor Finished comparisons for Google.Cloud.Speech.V2 |
2 participants
Changes in this PR