-
Notifications
You must be signed in to change notification settings - Fork 398
feat: API regeneration: 20260108T080111Z #15362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
feat: add a ClientContext field to Spanner requests feat: add Secure Parameters to the ClientContext PiperOrigin-RevId: 853323071 Source-Link: googleapis/googleapis@211d22f
Summary of ChangesHello @google-cloud-sdk-librarian-dotnet-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Google.Cloud.Spanner client library through an automated API regeneration process. The most notable change is the addition of a new mechanism to include client-specific context with API requests, enhancing the flexibility and functionality of Spanner interactions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated API regeneration for Google.Cloud.Spanner. The changes introduce a new ClientContext property to the RequestOptions class. All modifications are within generated files (Spanner.g.cs and pipeline-state.json). The code changes in Spanner.g.cs correctly and consistently implement the new property across all relevant methods, such as constructors, Equals, GetHashCode, and serialization/deserialization logic. The new ClientContext type itself is also generated correctly. The update to pipeline-state.json is a simple commit hash update, which is expected in this context. The changes are sound and I see no issues.
|
Pull request diff results Diff level: Minor Comparing with previous NuGet package Diff level: Minor Finished comparisons for Google.Cloud.Spanner.V1 |
Changes in this PR