Skip to content

Conversation

@google-cloud-sdk-librarian-dotnet-robot
Copy link
Collaborator

Changes in this PR

  • Generated Google.Cloud.Spanner

feat: add a ClientContext field to Spanner requests
feat: add Secure Parameters to the ClientContext


PiperOrigin-RevId: 853323071
Source-Link: googleapis/googleapis@211d22f
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @google-cloud-sdk-librarian-dotnet-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Google.Cloud.Spanner client library through an automated API regeneration process. The most notable change is the addition of a new mechanism to include client-specific context with API requests, enhancing the flexibility and functionality of Spanner interactions.

Highlights

  • API Regeneration: This pull request is an automated regeneration of the Google.Cloud.Spanner API client library.
  • New ClientContext in RequestOptions: A new ClientContext nested message has been introduced within the RequestOptions message. This context allows for passing client-owned information with requests.
  • Secure Context Map: The ClientContext includes a secure_context map, enabling the transmission of parameter name-value pairs that can be used by SECURE_CONTEXT() calls in Spanner queries.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be an automated API regeneration for Google.Cloud.Spanner. The changes introduce a new ClientContext property to the RequestOptions class. All modifications are within generated files (Spanner.g.cs and pipeline-state.json). The code changes in Spanner.g.cs correctly and consistently implement the new property across all relevant methods, such as constructors, Equals, GetHashCode, and serialization/deserialization logic. The new ClientContext type itself is also generated correctly. The update to pipeline-state.json is a simple commit hash update, which is expected in this context. The changes are sound and I see no issues.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Pull request diff results
Finding changes in Google.Cloud.Spanner.V1...
Comparing old and new versions (by source)
Minor changes:
Class 'RequestOptions'; property 'RequestOptions.Types.ClientContext ClientContext { get; set; }' added.
Class 'RequestOptions'; constant 'System.Int32 Google.Cloud.Spanner.V1.RequestOptions::ClientContextFieldNumber' added.
Class 'RequestOptions.Types.ClientContext' added.

Diff level: Minor

Comparing with previous NuGet package
Checking compatibility for Google.Cloud.Spanner.V1 version 5.9.0
Differences from 5.0.0
Minor changes:
Class 'CacheUpdate' added.
Class 'ChangeStreamRecord' added.
Enum 'ChangeStreamRecord.RecordOneofCase' added.
Class 'ChangeStreamRecord.Types' added.
Class 'ChangeStreamRecord.Types.DataChangeRecord' added.
Class 'ChangeStreamRecord.Types.DataChangeRecord.Types' added.
Class 'ChangeStreamRecord.Types.DataChangeRecord.Types.ColumnMetadata' added.
Class 'ChangeStreamRecord.Types.DataChangeRecord.Types.Mod' added.
Enum 'ChangeStreamRecord.Types.DataChangeRecord.Types.ModType' added.
Class 'ChangeStreamRecord.Types.DataChangeRecord.Types.ModValue' added.
Enum 'ChangeStreamRecord.Types.DataChangeRecord.Types.ValueCaptureType' added.
Class 'ChangeStreamRecord.Types.HeartbeatRecord' added.
Class 'ChangeStreamRecord.Types.PartitionEndRecord' added.
Class 'ChangeStreamRecord.Types.PartitionEventRecord' added.
Class 'ChangeStreamRecord.Types.PartitionEventRecord.Types' added.
Class 'ChangeStreamRecord.Types.PartitionEventRecord.Types.MoveInEvent' added.
Class 'ChangeStreamRecord.Types.PartitionEventRecord.Types.MoveOutEvent' added.
Class 'ChangeStreamRecord.Types.PartitionStartRecord' added.
Class 'ChangeStreamReflection' added.
Class 'CommitResponse'; property 'Timestamp SnapshotTimestamp { get; set; }' added.
Class 'CommitResponse'; constant 'System.Int32 Google.Cloud.Spanner.V1.CommitResponse::SnapshotTimestampFieldNumber' added.
Class 'ExecuteSqlRequest'; property 'RoutingHint RoutingHint { get; set; }' added.
Class 'ExecuteSqlRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.ExecuteSqlRequest::RoutingHintFieldNumber' added.
Class 'Group' added.
Class 'Interval' added.
Class 'KeyRecipe' added.
Enum 'KeyRecipe.TargetOneofCase' added.
Class 'KeyRecipe.Types' added.
Class 'KeyRecipe.Types.Part' added.
Class 'KeyRecipe.Types.Part.Types' added.
Enum 'KeyRecipe.Types.Part.Types.NullOrder' added.
Enum 'KeyRecipe.Types.Part.Types.Order' added.
Enum 'KeyRecipe.Types.Part.ValueTypeOneofCase' added.
Class 'LocationReflection' added.
Class 'Mutation'; property 'Mutation.Types.Ack Ack { get; set; }' added.
Class 'Mutation'; property 'Mutation.Types.Send Send { get; set; }' added.
Class 'Mutation'; constant 'System.Int32 Google.Cloud.Spanner.V1.Mutation::AckFieldNumber' added.
Class 'Mutation'; constant 'System.Int32 Google.Cloud.Spanner.V1.Mutation::SendFieldNumber' added.
Enum 'Mutation.OperationOneofCase' entry 'Ack' added.
Enum 'Mutation.OperationOneofCase' entry 'Send' added.
Class 'Mutation.Types.Ack' added.
Class 'Mutation.Types.Send' added.
Class 'PartialResultSet'; property 'CacheUpdate CacheUpdate { get; set; }' added.
Class 'PartialResultSet'; constant 'System.Int32 Google.Cloud.Spanner.V1.PartialResultSet::CacheUpdateFieldNumber' added.
Class 'QueryAdvisorResult' added.
Class 'QueryAdvisorResult.Types' added.
Class 'QueryAdvisorResult.Types.IndexAdvice' added.
Class 'QueryPlan'; property 'QueryAdvisorResult QueryAdvice { get; set; }' added.
Class 'QueryPlan'; constant 'System.Int32 Google.Cloud.Spanner.V1.QueryPlan::QueryAdviceFieldNumber' added.
Class 'Range' added.
Class 'ReadRequest'; property 'RoutingHint RoutingHint { get; set; }' added.
Class 'ReadRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.ReadRequest::RoutingHintFieldNumber' added.
Class 'RecipeList' added.
Class 'RequestOptions'; property 'RequestOptions.Types.ClientContext ClientContext { get; set; }' added.
Class 'RequestOptions'; constant 'System.Int32 Google.Cloud.Spanner.V1.RequestOptions::ClientContextFieldNumber' added.
Class 'RequestOptions.Types.ClientContext' added.
Class 'RoutingHint' added.
Class 'RoutingHint.Types' added.
Class 'RoutingHint.Types.SkippedTablet' added.
Class 'SpannerClientBuilder'; method 'CallInvoker CreateCallInvoker()' added.
Class 'SpannerClientBuilder'; method 'Task CreateCallInvokerAsync(CancellationToken cancellationToken)' added.
Class 'SpannerClientBuilder'; method 'void Validate()' added.
Class 'SpannerClientBuilder'; property 'ChannelPoolConfig AffinityChannelPoolConfiguration { get; set; }' added.
Class 'SpannerClientBuilder'; property 'Boolean CanUseChannelPool { get; }' added.
Class 'Tablet' added.
Class 'Tablet.Types' added.
Enum 'Tablet.Types.Role' added.
Dependency Google.Api.CommonProtos changed from v2.16.0.0 to v2.17.0.0
Dependency Google.Api.Gax changed from v4.9.0.0 to v4.12.1.0
Dependency Google.Api.Gax.Grpc changed from v4.9.0.0 to v4.12.1.0
Dependency Google.Cloud.Spanner.Common.V1 changed from v5.0.0.0 to v5.9.0.0
Dependency Google.Protobuf changed from v3.28.2.0 to v3.31.1.0

Diff level: Minor

Finished comparisons for Google.Cloud.Spanner.V1

@jskeet jskeet merged commit 27c4e5a into main Jan 8, 2026
14 checks passed
@jskeet jskeet deleted the librarian-regen-20260108T080111Z branch January 8, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants