feat: API regeneration: 20260109T080112Z #15365
Conversation
feat: A new service `BackupDrProtectionSummary` is added feat: A new message `ListResourceBackupConfigsRequest` is added feat: A new message `ListResourceBackupConfigsResponse` is added feat: A new message `ResourceBackupConfig` is added feat: A new resource_definition `backupdr.googleapis.com/ResourceBackupConfig` is added feat: A new message `BackupConfigDetails` is added feat: A new message `PitrSettings` is added feat: A new message `BackupDrTemplateConfig` is added feat: A new message `BackupDrPlanConfig` is added feat: A new message `BackupDrPlanRule` is added feat: A new message `BackupLocation` is added PiperOrigin-RevId: 854009996 Source-Link: googleapis/googleapis@524b2de
docs: Marking MODIFIED_CUSTOMER_INITIATED_ACCESS and MODIFIED_GOOGLE_INITIATED_SYSTEM_OPERATION Key Access Justification codes as deprecated in favor of GOOGLE_RESPONSE_TO_PRODUCTION_ALERT PiperOrigin-RevId: 853754070 Source-Link: googleapis/googleapis@f814267
feat: Add AIInference MessageTransform type docs: A comment for field `topic` in message `.google.pubsub.v1.Subscription` is updated docs: A comment for field `analytics_hub_subscription_info` in message `.google.pubsub.v1.Subscription` is updated docs: A comment for field `subscription` in message `.google.pubsub.v1.CreateSnapshotRequest` is updated PiperOrigin-RevId: 853856321 Source-Link: googleapis/googleapis@9fb55c4
chore: adjust initial_poll_delay for CreateDatabase and UpdateDatabaseDdl LRO operations PiperOrigin-RevId: 853884590 Source-Link: googleapis/googleapis@136a2c4
google-cloud-sdk-librarian-dotnet-robot
requested a review
from a team
as a code owner
Summary of ChangesHello @google-cloud-sdk-librarian-dotnet-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains an automated regeneration of several Google Cloud client libraries. The primary goal is to ensure that the client libraries for BackupDR, KMS, PubSub, and Spanner are up-to-date with the latest API definitions, incorporating new services like BackupDR and refining existing ones with minor documentation and deprecation updates. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Pull request diff results Diff level: Minor Comparing with previous NuGet package Diff level: Minor Finished comparisons for Google.Cloud.BackupDR.V1 Finding changes in Google.Cloud.Kms.V1... Comparing with previous NuGet package Finished comparisons for Google.Cloud.Kms.V1 Finding changes in Google.Cloud.PubSub.V1... Diff level: Minor Comparing with previous NuGet package Diff level: Minor Finished comparisons for Google.Cloud.PubSub.V1 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is an API regeneration, introducing several updates across different services. Notably, it adds a new BackupDrProtectionSummaryClient for the Google.Cloud.BackupDR.V1 API. For Google.Cloud.Kms.V1, it deprecates two AccessReason enum values, which is a significant change for users of this API. Additionally, there are minor documentation improvements in Google.Cloud.PubSub.V1 for better clarity. My review includes suggestions to enhance the developer experience regarding the deprecated enum values in the KMS API.
| /// resource in the same project or folder as the currently accessed resource | ||
| /// within the past 7 days. | ||
| /// </summary> | ||
| [global::System.ObsoleteAttribute] |
There was a problem hiding this comment.
For a better developer experience, it's recommended to add a descriptive message to the ObsoleteAttribute. This message will be displayed as part of the compiler warning, guiding users on how to address the deprecation. The XML documentation already contains a good explanation that could be summarized in the attribute.
[global::System.ObsoleteAttribute("This access reason is deprecated. Please refer to the documentation for alternatives.")]| /// resource in the same project or folder as the currently accessed resource | ||
| /// within the past 7 days. | ||
| /// </summary> | ||
| [global::System.ObsoleteAttribute] |
There was a problem hiding this comment.
For a better developer experience, it's recommended to add a descriptive message to the ObsoleteAttribute. This message will be displayed as part of the compiler warning, guiding users on how to address the deprecation. The XML documentation already contains a good explanation that could be summarized in the attribute.
[global::System.ObsoleteAttribute("This access reason is deprecated. Please refer to the documentation for alternatives.")]2 participants
Changes in this PR