-
Notifications
You must be signed in to change notification settings - Fork 398
chore: Library release: 20260121T170323Z #15398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Library release: 20260121T170323Z #15398
Conversation
### New features - Updated v3 dialogflow client libraries ### Bug fixes - An existing field `start_flow` is moved in to oneof in message `.google.cloud.dialogflow.cx.v3.Agent` - An existing field `webhook_ids` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` - An existing field `webhook_display_names` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` - An existing field `webhook_latencies` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` - An existing field `webhook_tags` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` ### Documentation improvements - Updated v3 dialogflow client libraries Librarian-Release-Library: Google.Cloud.Dialogflow.Cx.V3 Librarian-Release-Version: 3.0.0 Librarian-Release-ID: release-20260121T170323Z
Summary of ChangesHello @google-cloud-sdk-librarian-dotnet-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the release of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated library release for Google.Cloud.Dialogflow.Cx.V3, bumping the version to 3.0.0. The changes correctly update the version in the project file and metadata files. The release notes in history.md have been updated to reflect the changes in this new major version, which includes breaking changes. My feedback focuses on improving the clarity and accuracy of these release notes for better user understanding.
| ### Bug fixes | ||
|
|
||
| - An existing field `start_flow` is moved in to oneof in message `.google.cloud.dialogflow.cx.v3.Agent` | ||
| - An existing field `webhook_ids` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` | ||
| - An existing field `webhook_display_names` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` | ||
| - An existing field `webhook_latencies` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` | ||
| - An existing field `webhook_tags` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` | ||
|
|
||
| ### Documentation improvements | ||
|
|
||
| - Updated v3 dialogflow client libraries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release notes can be improved for clarity. The changes listed under "Bug fixes" are actually breaking changes, which justifies the major version bump to 3.0.0. It would be more accurate to rename this section to "Breaking Changes".
Additionally, the "Documentation improvements" section is redundant as it contains the same generic message as the "New features" section. To avoid confusion and keep the release notes concise, this redundant section should be removed.
| ### Bug fixes | |
| - An existing field `start_flow` is moved in to oneof in message `.google.cloud.dialogflow.cx.v3.Agent` | |
| - An existing field `webhook_ids` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` | |
| - An existing field `webhook_display_names` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` | |
| - An existing field `webhook_latencies` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` | |
| - An existing field `webhook_tags` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` | |
| ### Documentation improvements | |
| - Updated v3 dialogflow client libraries | |
| ### Breaking Changes | |
| - An existing field `start_flow` is moved in to oneof in message `.google.cloud.dialogflow.cx.v3.Agent` | |
| - An existing field `webhook_ids` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` | |
| - An existing field `webhook_display_names` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` | |
| - An existing field `webhook_latencies` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` | |
| - An existing field `webhook_tags` is removed from message `.google.cloud.dialogflow.cx.v3.QueryResult` |
|
Pull request diff results Comparing with previous NuGet package Minor changes: Diff level: Major Finished comparisons for Google.Cloud.Dialogflow.Cx.V3 |
1a23d08
into
main
Changes in this PR
Librarian-Release-ID: release-20260121T170323Z