-
Notifications
You must be signed in to change notification settings - Fork 398
chore: bump gRPC versions and centralize them #15402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jskeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines dependency management by updating a key gRPC ASP.NET Core package and centralizing the version declarations for several gRPC and Google API-related packages within Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to update and centralize gRPC package versions. The changes are generally moving in the right direction by utilizing Directory.Packages.props. However, I've identified a few areas for improvement. A temporary test file seems to have been included by accident. Additionally, one of the packages, Grpc.Net.Client, has had its local version override removed but hasn't been added to the central Directory.Packages.props file, which undermines the goal of centralization. Finally, there's a potential version mismatch between different grpc-dotnet packages which could lead to runtime issues. My detailed comments provide suggestions to address these points.
Directory.Packages.props
Outdated
| <!-- Default Grpc.Core versions: these should typically be changed together --> | ||
| <PackageVersion Include="Grpc.Core" Version="[2.46.6, 3.0.0)" /> | ||
| <PackageVersion Include="Grpc.Core.Testing" Version="[2.46.6, 3.0.0)" /> | ||
| <PackageVersion Include="Grpc.Core.Api" VersionOverride="2.71.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a potential version mismatch. Grpc.AspNetCore is being updated to 2.76.0 (on line 66), but Grpc.Core.Api is being set to 2.71.0. Since both are part of the grpc-dotnet ecosystem, their versions should ideally be aligned to prevent runtime errors like MethodNotFoundException. Please consider using version 2.76.0 for Grpc.Core.Api as well. Also, using Version instead of VersionOverride is more appropriate here since this package is a direct dependency in some projects, and VersionOverride is meant for forcing versions of transitive dependencies.
<PackageVersion Include="Grpc.Core.Api" Version="2.76.0" />
tools/Google.Cloud.Tools.ReleaseManager/Google.Cloud.Tools.ReleaseManager.csproj
Show resolved
Hide resolved
1d2ceb2 to
f88f76e
Compare
|
@amanda-tarafa The first version of this PR had a commit which introduced a file in Bigtable just to provoke the conformance tests - they passed. |
amanda-tarafa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.