Skip to content

Conversation

@jskeet
Copy link
Collaborator

@jskeet jskeet commented Jan 22, 2026

No description provided.

@jskeet jskeet requested review from a team as code owners January 22, 2026 10:39
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jskeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines dependency management by updating a key gRPC ASP.NET Core package and centralizing the version declarations for several gRPC and Google API-related packages within Directory.Packages.props. This approach simplifies future version updates and ensures consistent package versions across projects by removing individual VersionOverride attributes from various .csproj files, promoting a more maintainable and unified dependency landscape.

Highlights

  • gRPC Version Bump: The Grpc.AspNetCore package has been updated from version 2.40.0 to 2.76.0.
  • Centralized Version Management: Versions for Grpc.Core.Api (set to 2.71.0) and Google.Apis (set to 1.73.0) have been centralized in Directory.Packages.props.
  • Removed Version Overrides: Specific VersionOverride attributes for Google.Apis, Grpc.Core.Api, and Grpc.Net.Client have been removed from individual .csproj files, allowing them to inherit versions from Directory.Packages.props.
  • Temporary Test File: A new file apis/Google.Cloud.Bigtable.V2/test.txt was added, likely for testing purposes related to the version updates.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to update and centralize gRPC package versions. The changes are generally moving in the right direction by utilizing Directory.Packages.props. However, I've identified a few areas for improvement. A temporary test file seems to have been included by accident. Additionally, one of the packages, Grpc.Net.Client, has had its local version override removed but hasn't been added to the central Directory.Packages.props file, which undermines the goal of centralization. Finally, there's a potential version mismatch between different grpc-dotnet packages which could lead to runtime issues. My detailed comments provide suggestions to address these points.

<!-- Default Grpc.Core versions: these should typically be changed together -->
<PackageVersion Include="Grpc.Core" Version="[2.46.6, 3.0.0)" />
<PackageVersion Include="Grpc.Core.Testing" Version="[2.46.6, 3.0.0)" />
<PackageVersion Include="Grpc.Core.Api" VersionOverride="2.71.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There's a potential version mismatch. Grpc.AspNetCore is being updated to 2.76.0 (on line 66), but Grpc.Core.Api is being set to 2.71.0. Since both are part of the grpc-dotnet ecosystem, their versions should ideally be aligned to prevent runtime errors like MethodNotFoundException. Please consider using version 2.76.0 for Grpc.Core.Api as well. Also, using Version instead of VersionOverride is more appropriate here since this package is a direct dependency in some projects, and VersionOverride is meant for forcing versions of transitive dependencies.

    <PackageVersion Include="Grpc.Core.Api" Version="2.76.0" />

@jskeet jskeet force-pushed the bump-grpc branch 2 times, most recently from 1d2ceb2 to f88f76e Compare January 22, 2026 12:03
@jskeet jskeet requested a review from amanda-tarafa January 22, 2026 12:03
@jskeet
Copy link
Collaborator Author

jskeet commented Jan 22, 2026

@amanda-tarafa The first version of this PR had a commit which introduced a file in Bigtable just to provoke the conformance tests - they passed.

Copy link
Contributor

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jskeet jskeet merged commit 0bca68c into googleapis:main Jan 22, 2026
12 checks passed
@jskeet jskeet deleted the bump-grpc branch January 22, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants