-
Notifications
You must be signed in to change notification settings - Fork 398
feat: API configuration: 20260126T100110Z #15407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: API configuration: 20260126T100110Z #15407
Conversation
…loud/apiregistry/v1
Summary of ChangesHello @google-cloud-sdk-librarian-dotnet-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for the new Google Cloud API Registry V1 by adding its necessary configuration to the generator input files. This integration ensures that the SDK generation process can correctly handle and build libraries for this new API, enabling its use within the Google Cloud SDK. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Pull request diff results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the configuration for the Google.Cloud.ApiRegistry.V1 API. The changes in apis.json and pipeline-state.json are largely correct for adding a new API client. My review includes one suggestion to add a description for the new API in apis.json, which will improve the clarity and maintainability of the configuration.
generator-input/apis.json
Outdated
| "type": "grpc", | ||
| "productName": "Cloud API Registry", | ||
| "productUrl": "https://docs.cloud.google.com/api-registry/docs/overview", | ||
| "description": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description field is empty. Providing a description improves the clarity and maintainability of this configuration file. A suitable description can often be found on the product's overview page. I've suggested one below.
Additionally, the tags array is empty. Consider adding relevant tags if they apply.
| "description": "", | |
| "description": "The API Registry is a single place to upload and manage your APIs, regardless of where they are hosted.", |
|
Assigned @amanda-tarafa as I've added a second commit to fix the description. |
|
Pull request diff results |
Changes in this PR