Skip to content

chore: upgrade to Go 1.24 #12781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codyoss merged 4 commits into from
Sep 4, 2025
Merged

chore: upgrade to Go 1.24 #12781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
483f4f2
chore: upgrade to Go 1.24
codyoss Aug 26, 2025
e55398d
Merge branch 'to124' of github.com:codyoss/google-cloud-go; branch 'm…
codyoss Sep 2, 2025
a71cfff
fix vet issues
codyoss Sep 2, 2025
3fb52ea
Merge branch 'main' into to124
codyoss Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/apidiff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,16 @@
ref: main
- name: Get main commit
id: main
run: echo "hash=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT

Check warning on line 21 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:38: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/apidiff.yml:21:7: shellcheck reported issue in this script: SC2086:info:1:38: Double quote to prevent globbing and word splitting [shellcheck]
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.24.x'
go-version: '1.25.x'
- name: Get changed directories
id: changed_dirs
# Ignore changes to the internal and root directories.
# Ignore added files with --diff-filter=a.
run: |

Check warning on line 30 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:9:19: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/apidiff.yml:30:7: shellcheck reported issue in this script: SC2086:info:9:19: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 30 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:8:47: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/apidiff.yml:30:7: shellcheck reported issue in this script: SC2086:info:8:47: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 30 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:4:20: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/apidiff.yml:30:7: shellcheck reported issue in this script: SC2086:info:4:20: Double quote to prevent globbing and word splitting [shellcheck]
dirs=$(go run ./internal/actions/cmd/changefinder -q --diff-filter=a)
if [ -z "$dirs" ]
then
Expand All @@ -53,7 +53,7 @@
steps:
- uses: actions/setup-go@v5
with:
go-version: '1.24.x'
go-version: '1.25.x'
- name: Install latest apidiff
run: go install golang.org/x/exp/cmd/apidiff@latest
- uses: actions/checkout@v4
Expand All @@ -61,7 +61,7 @@
ref: main
- name: Create baseline
id: baseline
run: |

Check warning on line 64 in .github/workflows/apidiff.yml

View workflow job for this annotation

GitHub Actions / lint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:41: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/apidiff.yml:64:7: shellcheck reported issue in this script: SC2086:info:2:41: Double quote to prevent globbing and word splitting [shellcheck]
export CHANGED=${{ matrix.changed }}
echo pkg="${CHANGED//\//_}_pkg.main" >> $GITHUB_OUTPUT
- name: Create Go package baseline
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
matrix:
# Bigtable test proxy can be run on any of these Go versions
go: [ '1.23', '1.24']
go: [ '1.24', '1.25']
folders: ['bigtable']
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/new_client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@
fetch-depth: 2
- uses: actions/setup-go@v5
with:
go-version: 1.24.x
go-version: 1.25.x
- name: Find new version files
id: versions
# Ignore changes to the internal and root directories.
# Focus on newly added version.go files generated by GAPIC.
# Multiple new version files in a single module file will be deduped.
run: |

Check warning on line 32 in .github/workflows/new_client.yml

View workflow job for this annotation

GitHub Actions / lint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:9:19: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/new_client.yml:32:7: shellcheck reported issue in this script: SC2086:info:9:19: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 32 in .github/workflows/new_client.yml

View workflow job for this annotation

GitHub Actions / lint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:8:39: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/new_client.yml:32:7: shellcheck reported issue in this script: SC2086:info:8:39: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 32 in .github/workflows/new_client.yml

View workflow job for this annotation

GitHub Actions / lint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:4:20: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/new_client.yml:32:7: shellcheck reported issue in this script: SC2086:info:4:20: Double quote to prevent globbing and word splitting [shellcheck]
dirs=$(go run ./internal/actions/cmd/changefinder -q --base=HEAD~1 --diff-filter=A --path-filter='*version.go' --content-regex='internal\.Version')
if [ -z "$dirs" ]
then
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/owlbot_validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fetch-depth: 1
- uses: actions/setup-go@v5
with:
go-version: 1.24.x
go-version: 1.25.x
- run: |
git clone -b master --single-branch --depth=1 https://github.com/googleapis/googleapis.git
go run ./internal/postprocessor validate -googleapis-dir=./googleapis
2 changes: 1 addition & 1 deletion .github/workflows/third_party_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
fetch-depth: 2
- uses: actions/setup-go@v5
with:
go-version: 1.24.x
go-version: 1.25.x
- name: Find modified go.mod files
id: modfiles
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.24.x'
go-version: '1.25.x'
- name: Install tools
run: |
go install golang.org/x/lint/golint@latest && \
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ Our libraries are compatible with the two most recent major Go
releases, the same [policy](https://go.dev/doc/devel/release#policy) the Go
programming language follows. This means the currently supported versions are:

- Go 1.23
- Go 1.24
- Go 1.25

## Authentication

Expand Down
2 changes: 1 addition & 1 deletion accessapproval/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/accessapproval

go 1.23.0
go 1.24.0

require (
github.com/googleapis/gax-go/v2 v2.15.0
Expand Down
2 changes: 1 addition & 1 deletion accesscontextmanager/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/accesscontextmanager

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/iam v1.5.2
Expand Down
2 changes: 1 addition & 1 deletion advisorynotifications/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/advisorynotifications

go 1.23.0
go 1.24.0

require (
github.com/googleapis/gax-go/v2 v2.15.0
Expand Down
2 changes: 1 addition & 1 deletion ai/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/ai

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/longrunning v0.6.7
Expand Down
2 changes: 1 addition & 1 deletion aiplatform/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/aiplatform

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/iam v1.5.2
Expand Down
2 changes: 1 addition & 1 deletion alloydb/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/alloydb

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/longrunning v0.6.7
Expand Down
2 changes: 1 addition & 1 deletion analytics/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/analytics

go 1.23.0
go 1.24.0

require (
github.com/googleapis/gax-go/v2 v2.15.0
Expand Down
2 changes: 1 addition & 1 deletion apigateway/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/apigateway

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/longrunning v0.6.7
Expand Down
2 changes: 1 addition & 1 deletion apigeeconnect/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/apigeeconnect

go 1.23.0
go 1.24.0

require (
github.com/googleapis/gax-go/v2 v2.15.0
Expand Down
2 changes: 1 addition & 1 deletion apigeeregistry/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/apigeeregistry

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/iam v1.5.2
Expand Down
2 changes: 1 addition & 1 deletion apihub/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/apihub

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/longrunning v0.6.7
Expand Down
2 changes: 1 addition & 1 deletion apikeys/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/apikeys

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/longrunning v0.6.7
Expand Down
2 changes: 1 addition & 1 deletion appengine/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/appengine

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/longrunning v0.6.7
Expand Down
2 changes: 1 addition & 1 deletion apphub/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/apphub

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/iam v1.5.2
Expand Down
2 changes: 1 addition & 1 deletion apps/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/apps

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/longrunning v0.6.7
Expand Down
2 changes: 1 addition & 1 deletion area120/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/area120

go 1.23.0
go 1.24.0

require (
github.com/googleapis/gax-go/v2 v2.15.0
Expand Down
2 changes: 1 addition & 1 deletion artifactregistry/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/artifactregistry

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/iam v1.5.2
Expand Down
2 changes: 1 addition & 1 deletion asset/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/asset

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/accesscontextmanager v1.9.6
Expand Down
2 changes: 1 addition & 1 deletion assuredworkloads/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/assuredworkloads

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/longrunning v0.6.7
Expand Down
2 changes: 1 addition & 1 deletion auth/credentials/internal/externalaccount/externalaccount_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ func TestClient(t *testing.T) {
t.Fatalf("o.validate() = nil, want error")
}
if err != nil && !tc.wantErr {
t.Fatalf(err.Error())
t.Fatal(err.Error())
}

if tc.wantClientChanged {
Expand Down
2 changes: 1 addition & 1 deletion auth/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/auth

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/compute/metadata v0.8.0
Expand Down
2 changes: 1 addition & 1 deletion auth/oauth2adapt/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/auth/oauth2adapt

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/auth v0.16.5
Expand Down
2 changes: 1 addition & 1 deletion automl/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/automl

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/longrunning v0.6.7
Expand Down
2 changes: 1 addition & 1 deletion backupdr/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/backupdr

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/iam v1.5.2
Expand Down
2 changes: 1 addition & 1 deletion baremetalsolution/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/baremetalsolution

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/longrunning v0.6.7
Expand Down
2 changes: 1 addition & 1 deletion batch/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/batch

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/iam v1.5.2
Expand Down
2 changes: 1 addition & 1 deletion beyondcorp/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/beyondcorp

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/iam v1.5.2
Expand Down
2 changes: 1 addition & 1 deletion bigquery/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/bigquery

go 1.23.0
go 1.24.0

require (
cloud.google.com/go v0.121.6
Expand Down
2 changes: 1 addition & 1 deletion bigquery/v2/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/bigquery/v2

go 1.23.0
go 1.24.0

require (
cloud.google.com/go v0.121.6
Expand Down
2 changes: 1 addition & 1 deletion bigtable/bigtable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2043,7 +2043,7 @@ func (t *Table) doApplyBulk(ctx context.Context, entryErrs []*entryErr, headerMD
if s.Code == int32(codes.OK) {
entryErrs[entry.Index].Err = nil
} else {
entryErrs[entry.Index].Err = status.Errorf(codes.Code(s.Code), s.Message)
entryErrs[entry.Index].Err = status.Error(codes.Code(s.Code), s.Message)
}
}
after(res)
Expand Down
2 changes: 1 addition & 1 deletion bigtable/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/bigtable

go 1.23.0
go 1.24.0

require (
cloud.google.com/go v0.121.6
Expand Down
5 changes: 3 additions & 2 deletions bigtable/metrics_util_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ limitations under the License.
package bigtable

import (
"errors"
"fmt"
"testing"

Expand Down Expand Up @@ -152,7 +153,7 @@ func TestExtractLocation(t *testing.T) {
trailerMD: metadata.MD{},
wantCluster: defaultCluster,
wantZone: defaultZone,
wantError: fmt.Errorf(invalidFormatErr),
wantError: errors.New(invalidFormatErr),
},
{
desc: "Invalid location metadata format in trailer",
Expand All @@ -162,7 +163,7 @@ func TestExtractLocation(t *testing.T) {
},
wantCluster: defaultCluster,
wantZone: defaultZone,
wantError: fmt.Errorf(invalidFormatErr),
wantError: errors.New(invalidFormatErr),
},
}

Expand Down
2 changes: 1 addition & 1 deletion bigtable/retry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func TestRetryApply(t *testing.T) {
errInjector := func(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) {
if strings.HasSuffix(info.FullMethod, "MutateRow") && errCount < 3 {
errCount++
return nil, status.Errorf(code, errMsg)
return nil, status.Error(code, errMsg)
}
return handler(ctx, req)
}
Expand Down
8 changes: 4 additions & 4 deletions bigtable/type_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,14 +275,14 @@ func TestAggregateProto(t *testing.T) {
},
},
}}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
for i := range testCases {
t.Run(testCases[i].name, func(t *testing.T) {
want := &btapb.Type{
Kind: &btapb.Type_AggregateType{
AggregateType: &tc.protoAgg,
AggregateType: &testCases[i].protoAgg,
},
}
at := AggregateType{Input: Int64Type{Encoding: BigEndianBytesEncoding{}}, Aggregator: tc.agg}
at := AggregateType{Input: Int64Type{Encoding: BigEndianBytesEncoding{}}, Aggregator: testCases[i].agg}

assertType(t, at, want)
})
Expand Down
2 changes: 1 addition & 1 deletion billing/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/billing

go 1.23.0
go 1.24.0

require (
cloud.google.com/go/iam v1.5.2
Expand Down
2 changes: 1 addition & 1 deletion binaryauthorization/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module cloud.google.com/go/binaryauthorization

go 1.23.0
go 1.24.0

require (
github.com/googleapis/gax-go/v2 v2.15.0
Expand Down
Loading
Loading