chore(vertexai): Improve the test helpers.#14178
Merged
BenjaminKazemi merged 1 commit intogoogleapis:mainfrom Mar 16, 2026
Merged
chore(vertexai): Improve the test helpers.#14178BenjaminKazemi merged 1 commit intogoogleapis:mainfrom
BenjaminKazemi merged 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the test helpers by centralizing them into a new test_helper.go file. This significantly reduces code duplication across test files. The introduction of a generic waitForOperation function using generics and reflection is a clever way to handle various long-running operations. The tests are also improved, for example by adding value assertions in the "Get" agent engine test. I have one suggestion to improve consistency in one of the new helper functions.
BenjaminKazemi
force-pushed
the
vertexai_test_helper
branch
from
37184b9 to
e6945f6
Compare
BenjaminKazemi
force-pushed
the
vertexai_test_helper
branch
from
e6945f6 to
d6d5b13
Compare
jscud
approved these changes
Mar 16, 2026
BenjaminKazemi
force-pushed
the
vertexai_test_helper
branch
from
d6d5b13 to
2c7902d
Compare
BenjaminKazemi
force-pushed
the
vertexai_test_helper
branch
from
2c7902d to
d47644b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(vertexai): Improve the test helpers.