chore(vertexai): Clean up the internal Agent Engine structs.#14184
Merged
BenjaminKazemi merged 1 commit intogoogleapis:mainfrom Mar 17, 2026
Merged
chore(vertexai): Clean up the internal Agent Engine structs.#14184BenjaminKazemi merged 1 commit intogoogleapis:mainfrom
BenjaminKazemi merged 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request provides a good cleanup of the internal Agent Engine structs by removing redundant code for handling config parameters. The changes are applied consistently across multiple files (agentengines.go, memories.go, memoryrevisions.go, sandboxes.go, sessionevents.go, sessions.go). For functions that process configurations, the redundant assignment after a helper call is removed, relying on the helper to modify the request object directly. For functions where the configuration was not used, the related code blocks are deleted entirely. These changes improve code clarity and maintainability.
jscud
reviewed
Mar 16, 2026
BenjaminKazemi
force-pushed
the
vertexai_test_helper
branch
3 times, most recently
from
f6fe701 to
e230439
Compare
jscud
approved these changes
Mar 17, 2026
BenjaminKazemi
force-pushed
the
vertexai_test_helper
branch
from
e230439 to
4ee5328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(vertexai): Clean up the internal Agent Engine structs.