Skip to content

build: integrate nodejs core libraries #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sofisl merged 29 commits into from
Dec 3, 2025
Merged

build: integrate nodejs core libraries #848

sofisl merged 29 commits into from
Dec 3, 2025

Conversation

@sofisl
Copy link
Collaborator

@sofisl sofisl commented Nov 22, 2025 •
edited
Loading

see https://docs.google.com/document/d/1qGdqMm65qMdCx8IidtWUAFLyxSPjMgDeps9IWFgjY_U/edit?resourcekey=0-Q-jGBtkPkoMRIiGRMZ5HJQ&tab=t.0#heading=h.b39qvqs1v80r

This PR does a few things:

  1. Adds a bash script that runs interdependent tests, and replaces it in ci.yaml
  2. Adds a syncpack action. Syncpack makes sure we have compatible dependencies.
  3. Moves logging-utils to packages, since it's a dependency, not a dev dependency (it's used for customer logging and telemetry)
  4. Runs syncpack fix-mismatches to make sure dependencies are compatible.

@sofisl sofisl requested a review from a team as a code owner November 22, 2025 00:00
sofisl and others added 11 commits November 21, 2025 16:11
@sofisl
fix
ba8aff7
@sofisl
fix(ci): make run-interdependent-tests.sh safer
510debe 
The script was failing when running in a directory that does not have a 'packages' subdirectory. This commit adds a check to ensure the directory exists before trying to list its contents.
@sofisl
fix(deps): syncpack dependency versions
b3cd250 
This commit fixes the dependency mismatches reported by syncpack.
@sofisl
fix(ts): address type errors from @types/node update
1e3f3cd 
This commit fixes the TypeScript errors that were introduced after updating the dependencies with syncpack. The errors were related to the new definition of Uint8Array in @types/node.
@sofisl
ci(syncpack): automate fixing of mismatches
213a2dd 
This commit updates the syncpack workflow to automatically fix dependency mismatches and commit the changes.
@sofisl
Merge branch 'main' into integrateNodejsClientLibs
1609e3a
@sofisl
Update package.json
cef80c9
@sofisl
revert(ci): remove automated fix for syncpack
75a06eb 
This reverts the previous commit that automated the fixing of syncpack mismatches.
@sofisl
fix(deps): update dependencies to resolve syncpack mismatches
5ad7f21
@sofisl
fix(proto3-json-serializer): resolve Uint8Array and Buffer type issues
2ca2439
@sofisl
run lint
f67ca1f
@sofisl sofisl changed the title build: Integrate nodejs client libs build: integrate nodejs core libraries Nov 22, 2025
miguelvelezsa
miguelvelezsa reviewed Dec 2, 2025
View reviewed changes
@sofisl sofisl merged commit 4b4ec05 into main Dec 3, 2025
13 checks passed
@sofisl sofisl deleted the integrateNodejsClientLibs branch December 3, 2025 19:46
miguelvelezsa added a commit that referenced this pull request Dec 3, 2025
@sofisl @miguelvelezsa
build: integrate nodejs core libraries (#848)
669b37c 
* build: run interdependent tests

* build: run interdependent tests

* fix

* fix(ci): make run-interdependent-tests.sh safer

The script was failing when running in a directory that does not have a 'packages' subdirectory. This commit adds a check to ensure the directory exists before trying to list its contents.

* fix(deps): syncpack dependency versions

This commit fixes the dependency mismatches reported by syncpack.

* fix(ts): address type errors from @types/node update

This commit fixes the TypeScript errors that were introduced after updating the dependencies with syncpack. The errors were related to the new definition of Uint8Array in @types/node.

* ci(syncpack): automate fixing of mismatches

This commit updates the syncpack workflow to automatically fix dependency mismatches and commit the changes.

* Update package.json

* revert(ci): remove automated fix for syncpack

This reverts the previous commit that automated the fixing of syncpack mismatches.

* fix(deps): update dependencies to resolve syncpack mismatches

* fix(proto3-json-serializer): resolve Uint8Array and Buffer type issues

* run lint

* feat: add top-level lint-fix script

This commit adds a top-level lint-fix script that runs  in all packages. It also fixes an issue in  package that was causing the linting to fail.

* fix(lint): run gts fix on all packages

* chore: make sure we are actually installing packages locally

* remove the package-lock.json

* fix

* chore: fix

* retry

* chore: fix

* Update continuous.yaml

* run lint

* chore: fix nodejs runtime

* address comments

* remove numbers

* pin typescript dependency

---------

Co-authored-by: miguel <miguelvelezsa@google.com>
miguelvelezsa added a commit that referenced this pull request Dec 3, 2025
@sofisl @miguelvelezsa
build: integrate nodejs core libraries (#848)
278e0c0 
* build: run interdependent tests

* build: run interdependent tests

* fix

* fix(ci): make run-interdependent-tests.sh safer

The script was failing when running in a directory that does not have a 'packages' subdirectory. This commit adds a check to ensure the directory exists before trying to list its contents.

* fix(deps): syncpack dependency versions

This commit fixes the dependency mismatches reported by syncpack.

* fix(ts): address type errors from @types/node update

This commit fixes the TypeScript errors that were introduced after updating the dependencies with syncpack. The errors were related to the new definition of Uint8Array in @types/node.

* ci(syncpack): automate fixing of mismatches

This commit updates the syncpack workflow to automatically fix dependency mismatches and commit the changes.

* Update package.json

* revert(ci): remove automated fix for syncpack

This reverts the previous commit that automated the fixing of syncpack mismatches.

* fix(deps): update dependencies to resolve syncpack mismatches

* fix(proto3-json-serializer): resolve Uint8Array and Buffer type issues

* run lint

* feat: add top-level lint-fix script

This commit adds a top-level lint-fix script that runs  in all packages. It also fixes an issue in  package that was causing the linting to fail.

* fix(lint): run gts fix on all packages

* chore: make sure we are actually installing packages locally

* remove the package-lock.json

* fix

* chore: fix

* retry

* chore: fix

* Update continuous.yaml

* run lint

* chore: fix nodejs runtime

* address comments

* remove numbers

* pin typescript dependency

---------

Co-authored-by: miguel <miguelvelezsa@google.com>
miguelvelezsa added a commit that referenced this pull request Dec 3, 2025
@sofisl @miguelvelezsa
build: integrate nodejs core libraries (#848)
2dedd87 
* build: run interdependent tests

* build: run interdependent tests

* fix

* fix(ci): make run-interdependent-tests.sh safer

The script was failing when running in a directory that does not have a 'packages' subdirectory. This commit adds a check to ensure the directory exists before trying to list its contents.

* fix(deps): syncpack dependency versions

This commit fixes the dependency mismatches reported by syncpack.

* fix(ts): address type errors from @types/node update

This commit fixes the TypeScript errors that were introduced after updating the dependencies with syncpack. The errors were related to the new definition of Uint8Array in @types/node.

* ci(syncpack): automate fixing of mismatches

This commit updates the syncpack workflow to automatically fix dependency mismatches and commit the changes.

* Update package.json

* revert(ci): remove automated fix for syncpack

This reverts the previous commit that automated the fixing of syncpack mismatches.

* fix(deps): update dependencies to resolve syncpack mismatches

* fix(proto3-json-serializer): resolve Uint8Array and Buffer type issues

* run lint

* feat: add top-level lint-fix script

This commit adds a top-level lint-fix script that runs  in all packages. It also fixes an issue in  package that was causing the linting to fail.

* fix(lint): run gts fix on all packages

* chore: make sure we are actually installing packages locally

* remove the package-lock.json

* fix

* chore: fix

* retry

* chore: fix

* Update continuous.yaml

* run lint

* chore: fix nodejs runtime

* address comments

* remove numbers

* pin typescript dependency

---------

Co-authored-by: miguel <miguelvelezsa@google.com>
miguelvelezsa added a commit that referenced this pull request Dec 4, 2025
@sofisl @miguelvelezsa
build: integrate nodejs core libraries (#848)
d40a130 
* build: run interdependent tests

* build: run interdependent tests

* fix

* fix(ci): make run-interdependent-tests.sh safer

The script was failing when running in a directory that does not have a 'packages' subdirectory. This commit adds a check to ensure the directory exists before trying to list its contents.

* fix(deps): syncpack dependency versions

This commit fixes the dependency mismatches reported by syncpack.

* fix(ts): address type errors from @types/node update

This commit fixes the TypeScript errors that were introduced after updating the dependencies with syncpack. The errors were related to the new definition of Uint8Array in @types/node.

* ci(syncpack): automate fixing of mismatches

This commit updates the syncpack workflow to automatically fix dependency mismatches and commit the changes.

* Update package.json

* revert(ci): remove automated fix for syncpack

This reverts the previous commit that automated the fixing of syncpack mismatches.

* fix(deps): update dependencies to resolve syncpack mismatches

* fix(proto3-json-serializer): resolve Uint8Array and Buffer type issues

* run lint

* feat: add top-level lint-fix script

This commit adds a top-level lint-fix script that runs  in all packages. It also fixes an issue in  package that was causing the linting to fail.

* fix(lint): run gts fix on all packages

* chore: make sure we are actually installing packages locally

* remove the package-lock.json

* fix

* chore: fix

* retry

* chore: fix

* Update continuous.yaml

* run lint

* chore: fix nodejs runtime

* address comments

* remove numbers

* pin typescript dependency

---------

Co-authored-by: miguel <miguelvelezsa@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miguelvelezsa miguelvelezsa miguelvelezsa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sofisl @miguelvelezsa