Skip to content

Conversation

@thiyaguk09
Copy link
Contributor

Storage added ability to configure and utilize soft-delete and restore buckets

initial commit for bucket restore
lint fix
@thiyaguk09 thiyaguk09 requested review from a team as code owners December 24, 2024 10:11
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Dec 24, 2024
@JesseLovelace
Copy link

LGTM, but don't merge without review from a PHP language expert

Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is LGTM, but with two small suggestions!

Addressed the review comments.
@thiyaguk09 thiyaguk09 requested a review from bshaffer December 30, 2024 05:01
@bshaffer bshaffer merged commit 944287d into googleapis:main Jan 6, 2025
26 checks passed
elrido added a commit to PrivateBin/PrivateBin that referenced this pull request Jan 11, 2025
Adds new method required by interface since googleapis/google-cloud-php#7966
elrido added a commit to PrivateBin/PrivateBin that referenced this pull request Jan 11, 2025
Adds new method required by interface since googleapis/google-cloud-php#7966
@bshaffer
Copy link
Contributor

bshaffer commented Mar 6, 2025

Samples for this are being added here: GoogleCloudPlatform/php-docs-samples#2067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants