Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jul 16, 2025

@parthea parthea changed the title [WIP] chore: add librarian state.yaml chore: add librarian state.yaml Jul 16, 2025
@parthea
Copy link
Contributor Author

parthea commented Jul 16, 2025

I'm still working on adding tests

@parthea parthea marked this pull request as ready for review July 17, 2025 17:59
@parthea parthea requested a review from a team as a code owner July 17, 2025 17:59
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2025
ohmayr
ohmayr previously approved these changes Jul 18, 2025
remove_regex: ''
sourcePaths:
- packages/google-cloud-language
version: 2.17.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file and link an issue here to remove this file once we're done with our local testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't be deleting state.yaml. The plan is to have an initial state.yaml when we onboard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Librarian will be creating the state.yaml file and maintaining it once we have configure implemented. Ideally, state.yaml shouldn't have any manual edits.

We're only creating this file for the first milestone. Once we've got configure in place, Librarian should create and place the state.yaml file in the /.librarian folder.

Why do we want an initial handwritten state.yaml (apart from the first milestone)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Librarian will be creating the state.yaml file

Let's sync offline on this. My initial thought is that we will create the initial state.yaml, and update it as needed, and Librarian will fully take over state.yaml only once we've completed the migration from owlbot->librarian.

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 18, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 18, 2025
@parthea parthea enabled auto-merge (squash) July 18, 2025 20:04
remove_regex: ''
sourcePaths:
- packages/google-cloud-language
version: 2.17.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Librarian will be creating the state.yaml file and maintaining it once we have configure implemented. Ideally, state.yaml shouldn't have any manual edits.

We're only creating this file for the first milestone. Once we've got configure in place, Librarian should create and place the state.yaml file in the /.librarian folder.

Why do we want an initial handwritten state.yaml (apart from the first milestone)?

@parthea parthea merged commit 385ba52 into main Jul 18, 2025
21 checks passed
@parthea parthea deleted the add-state-yaml branch July 18, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google-cloud-python: Create initial state.yaml

2 participants