Skip to content

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Jul 17, 2025

This PR implements a minimalistic Dockerfile which runs the required CLI commands for Librarian.

Testing steps:

docker build . -t <image-name>

Command:

docker run --rm <image-name>

Output:

'generate' command executed.

Fixes: googleapis/librarian#899

@ohmayr ohmayr requested a review from a team as a code owner July 17, 2025 22:37
@ohmayr ohmayr requested a review from vchudnov-g July 21, 2025 18:26
@ohmayr ohmayr merged commit b886e1d into main Jul 21, 2025
22 checks passed
@ohmayr ohmayr deleted the initial-setup-for-librarian-workflow branch July 21, 2025 19:31
from cli import handle_generate, handle_build, handle_configure


def test_handle_configure_dry_run():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you also have tests with dry_run=False?

I could imagine that when dry_run=False, you could accumulate the commands that would be yielded by dry_run=True and pass them to a function execute_run that will execute them. In that case, the tests for dry_run=False need merely verify that the invocations all call execute_run with the expected parameters, and then we only need a single additional test for execute_run that it executes a given test command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a Dockerfile Image with simple cli commands

3 participants