feat: read content of generate request #14113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
force-pushed
the
read-generate-request-file
branch
from
89b9518 to
7b60921
Compare
ohmayr
force-pushed
the
read-generate-request-file
branch
from
7b60921 to
fbb164e
Compare
vchudnov-g
reviewed
Jul 21, 2025
.librarian/generate-request.json
Outdated
| @@ -0,0 +1,10 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Real generation requests will go in this path, correct? So this actual file is just test data? If so; I suggest
- place this file under some sort of test directory (call it
$LIBRARIAN_TEST_DIRin this discussion) - configure the CLI to set the variable
$LIBRARIANto the value of the environment variable$LIBRARIAN_DIRif it exists, or otherwise the default you already have - when you run
test_handle_generate, set$LIBRARIAN_DIRto have the value of$LIBRARIAN_TEST_DIRso it reads the input from the test dir.
Contributor
Author
There was a problem hiding this comment.
I've addressed this comment. However, my initial intention was to remove this file once we complete the work since we don't need it (i.e. we only need it for local testing). We won't be testing bazelisk commands in our unit tests. Let me know what you think.
parthea
previously approved these changes
Jul 22, 2025
parthea
approved these changes
Jul 22, 2025
vchudnov-g
reviewed
Jul 22, 2025
Contributor
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
Looks good. Thanks for your changes.
| Returns: | ||
| dict: The parsed JSON content. | ||
| Raises: |
Contributor
There was a problem hiding this comment.
The exceptions specify the file path? Cool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14122