-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: Kaniko build #14158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Kaniko build #14158
Conversation
| # Copy the CLI script into the container. | ||
| COPY .generator/cli.py . | ||
| COPY --chown=$UID:$GID .generator/cli.py . | ||
| RUN chmod a+rx ./cli.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this after the command to copy bazel cache to speed up the feedback loop while we're testing. The reason is that cli.py will change more frequently than the bazel cache in the short term.
.generator/Dockerfile
Outdated
|
|
||
| COPY --from=builder --chown=$UID:$GID /bazel_cache /bazel_cache | ||
|
|
||
| # RUN chown $UID:$GID -R /app /.cache /bazel_cache /source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented code
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #14142 🦕