Skip to content

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Jul 29, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #14142 🦕

# Copy the CLI script into the container.
COPY .generator/cli.py .
COPY --chown=$UID:$GID .generator/cli.py .
RUN chmod a+rx ./cli.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this after the command to copy bazel cache to speed up the feedback loop while we're testing. The reason is that cli.py will change more frequently than the bazel cache in the short term.


COPY --from=builder --chown=$UID:$GID /bazel_cache /bazel_cache

# RUN chown $UID:$GID -R /app /.cache /bazel_cache /source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code

@ohmayr ohmayr closed this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce the build time for .generator/Dockerfile

2 participants