Skip to content

chore(librarian): rename source_commit_hash to commit_hash #14737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 1 commit into from
Oct 16, 2025
Merged

chore(librarian): rename source_commit_hash to commit_hash #14737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .generator/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,7 +1207,7 @@ def _process_changelog(

# Group changes by type (e.g., feat, fix, docs)
type_key = "type"
source_commit_hash_key = "source_commit_hash"
commit_hash_key = "commit_hash"
subject_key = "subject"
body_key = "body"
library_changes.sort(key=lambda x: x[type_key])
Expand All @@ -1224,7 +1224,7 @@ def _process_changelog(
if adjusted_change_type in change_type_map:
entry_parts.append(f"\n\n### {change_type_map[adjusted_change_type]}\n")
for change in library_changes:
commit_link = f"([{change[source_commit_hash_key]}]({_REPO_URL}/commit/{change[source_commit_hash_key]}))"
commit_link = f"([{change[commit_hash_key]}]({_REPO_URL}/commit/{change[commit_hash_key]}))"
entry_parts.append(
f"* {change[subject_key]} {change[body_key]} {commit_link}"
)
Expand Down
8 changes: 4 additions & 4 deletions .generator/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,28 +83,28 @@
"subject": "add new UpdateRepository API",
"body": "This adds the ability to update a repository's properties.",
"piper_cl_number": "786353207",
"source_commit_hash": "9461532e7d19c8d71709ec3b502e5d81340fb661",
"commit_hash": "9461532e7d19c8d71709ec3b502e5d81340fb661",
},
{
"type": "fix",
"subject": "some fix",
"body": "some body",
"piper_cl_number": "786353208",
"source_commit_hash": "1231532e7d19c8d71709ec3b502e5d81340fb661",
"commit_hash": "1231532e7d19c8d71709ec3b502e5d81340fb661",
},
{
"type": "fix",
"subject": "another fix",
"body": "",
"piper_cl_number": "786353209",
"source_commit_hash": "1241532e7d19c8d71709ec3b502e5d81340fb661",
"commit_hash": "1241532e7d19c8d71709ec3b502e5d81340fb661",
},
{
"type": "docs",
"subject": "fix typo in BranchRule comment",
"body": "",
"piper_cl_number": "786353210",
"source_commit_hash": "9461532e7d19c8d71709ec3b502e5d81340fb661",
"commit_hash": "9461532e7d19c8d71709ec3b502e5d81340fb661",
},
]

Expand Down
Loading