Skip to content

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Oct 21, 2025

feat: onboard a new library

PiperOrigin-RevId: 805881130
Library-IDs: google-cloud-gkerecommender
Librarian Version: v0.4.1-0.20251016202915-811eb8e2da4e
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator:latest

@ohmayr ohmayr requested review from a team as code owners October 21, 2025 08:04
@snippet-bot
Copy link

snippet-bot bot commented Oct 21, 2025

Here is the summary of changes.

You are about to add 12 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@parthea
Copy link
Contributor

parthea commented Oct 21, 2025

Blocked by googleapis/librarian#2628

@@ -0,0 +1 @@
# Changelog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the anchor described here to avoid this stack trace

Traceback (most recent call last):
  File "/app/./cli.py", line 1466, in handle_release_init
    _update_changelog_for_library(
  File "/app/./cli.py", line 1375, in _update_changelog_for_library
    updated_content = _process_changelog(
  File "/app/./cli.py", line 1344, in _process_changelog
    raise ValueError("Changelog anchor '[1]: ...#history' not found.")
ValueError: Changelog anchor '[1]: ...#history' not found.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/app/./cli.py", line 1560, in <module>
    args.func(librarian=args.librarian, repo=args.repo, output=args.output)
  File "/app/./cli.py", line 1477, in handle_release_init
    raise ValueError(f"Release init failed: {e}") from e
ValueError: Release init failed: Changelog anchor '[1]: ...#history' not found.

@@ -0,0 +1 @@
# Changelog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an assumption that this file will be a symlink and doesn't need to be updated. I believe this file will become stale if it's not a symlink. Otherwise, we will need to add logic here to also update docs/CHANGELOG.md

if is_mono_repo:
path_to_library = f"packages/{library_id}"
changelog_relative_path = f"packages/{library_id}/CHANGELOG.md"
else:
path_to_library = "."
changelog_relative_path = "CHANGELOG.md"
_update_version_for_library(repo, output, path_to_library, version)
_update_changelog_for_library(
repo,
output,
library_changes,
version,
previous_version,
library_id,
relative_path=changelog_relative_path,
)

@parthea parthea closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: blocked Resolving the issue is dependent on other work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants