-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: librarian generate pull request: 20260108T222925Z #15010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Google Cloud Compute Engine v1 client library by integrating new services and expanding existing functionalities. The changes provide developers with access to advanced features for network management, resource reservation, and refined access control mechanisms, ensuring the client library remains current with the latest platform capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Adding We can remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be automatically generated to update the Compute Engine v1 API. The changes are extensive and mostly involve adding new services and updating existing ones. My review focused on the generated Python code. I've identified several minor formatting issues in the docstrings across multiple files, where words are incorrectly concatenated during line re-wrapping (e.g., readGPUs instead of read GPUs). I have provided comments on a representative set of these issues. It is highly recommended to fix the underlying generator to prevent these issues in future updates and to apply the fixes to all occurrences in this pull request for consistency and improved documentation quality.
packages/google-cloud-compute/google/cloud/compute_v1/services/accelerator_types/client.py
Show resolved
Hide resolved
...s/google-cloud-compute/google/cloud/compute_v1/services/accelerator_types/transports/rest.py
Show resolved
Hide resolved
packages/google-cloud-compute/google/cloud/compute_v1/services/addresses/client.py
Show resolved
Hide resolved
packages/google-cloud-compute/google/cloud/compute_v1/services/addresses/transports/rest.py
Show resolved
Hide resolved
| autoscaler resource. | ||
| For regional managed instance groups, use | ||
| theregionAutoscalers resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [Global](https://cloud.google.com/compute/docs/reference/rest/v1/backendServices) | ||
| - [Regional](https://cloud.google.com/compute/docs/reference/rest/v1/regionBackendServices) | ||
| For more information, seeBackend Services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| previously made from the disk. You must separatelydelete | ||
| snapshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| instances. For more information, read | ||
| Firewall rules. | ||
| instances. For more information, | ||
| readFirewall rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| method supportsPATCH semantics and usesJSON merge | ||
| patch format and processing rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are minor formatting issues in the docstring. supportsPATCH should be supports PATCH and usesJSON should be uses JSON to improve readability.
| method supportsPATCH semantics and usesJSON merge | |
| patch format and processing rules. | |
| method supports PATCH semantics and uses JSON merge patch | |
| format and processing rules. |
| r"""Returns the latest image that is part of an image | ||
| family and is not deprecated. For more information on | ||
| image families, see Public image families documentation. | ||
| image families, seePublic image families documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Update Compute Engine v1 API to revision 20251210 (#1137)
PiperOrigin-RevId:
Library-IDs: google-cloud-compute
Source-link: googleapis/googleapis@c2ec846d
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Update Compute Engine v1 API to revision 20251031
PiperOrigin-RevId:
Library-IDs: google-cloud-compute
Source-link: googleapis/googleapis@4667f02b
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@33225118
(exclusive) and
googleapis/googleapis@c2ec846d
(inclusive).
Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209