Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 8, 2026

PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.

BEGIN_COMMIT

BEGIN_NESTED_COMMIT
feat: Update Compute Engine v1 API to revision 20251210 (#1137)

PiperOrigin-RevId:
Library-IDs: google-cloud-compute
Source-link: googleapis/googleapis@c2ec846d
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: Update Compute Engine v1 API to revision 20251031

PiperOrigin-RevId:
Library-IDs: google-cloud-compute
Source-link: googleapis/googleapis@4667f02b
END_NESTED_COMMIT

END_COMMIT

This pull request is generated with proto changes between
googleapis/googleapis@33225118
(exclusive) and
googleapis/googleapis@c2ec846d
(inclusive).

Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209

@parthea parthea requested review from a team as code owners January 8, 2026 22:30
@snippet-bot
Copy link

snippet-bot bot commented Jan 8, 2026

Here is the summary of changes.

You are about to add 25 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Google Cloud Compute Engine v1 client library by integrating new services and expanding existing functionalities. The changes provide developers with access to advanced features for network management, resource reservation, and refined access control mechanisms, ensuring the client library remains current with the latest platform capabilities.

Highlights

  • New Services Introduced: This update introduces four new services to the Compute Engine v1 API client library: Advice, CrossSiteNetworks, FutureReservations, and WireGroups, each with their respective clients, pagers, and REST transports.
  • API Expansion and New Types: Numerous new types and methods have been added across the API, including detailed types for Accelerator Topologies, Calendar Mode Advice, Cross-Site Networks, Future Reservations, gRPC TLS Health Checks, Interconnect Attachment L2 Forwarding, and Wire Groups. Existing services like Firewalls, Reservations, and ResourcePolicies now include new IAM-related methods such as test_iam_permissions, get_iam_policy, and set_iam_policy.
  • Documentation and Code Formatting Improvements: Minor documentation formatting and code style adjustments have been applied across various client and transport files for improved readability and consistency.
  • Automated Library Update: The pull request represents an automated update of the Google Cloud Compute Engine v1 client library, generated by the Librarian CLI to reflect recent API revisions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 8, 2026
@parthea
Copy link
Contributor Author

parthea commented Jan 8, 2026

Adding do not merge label as there is a release pending: #15005

We can remove the do not merge label once the release PR is merged.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be automatically generated to update the Compute Engine v1 API. The changes are extensive and mostly involve adding new services and updating existing ones. My review focused on the generated Python code. I've identified several minor formatting issues in the docstrings across multiple files, where words are incorrectly concatenated during line re-wrapping (e.g., readGPUs instead of read GPUs). I have provided comments on a representative set of these issues. It is highly recommended to fix the underlying generator to prevent these issues in future updates and to apply the fixes to all occurrences in this pull request for consistency and improved documentation quality.

autoscaler resource.
For regional managed instance groups, use
theregionAutoscalers resource.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a minor formatting issue in the docstring. theregionAutoscalers should be the regionAutoscalers to improve readability.

Suggested change
theregionAutoscalers resource.
the regionAutoscalers resource.

- [Global](https://cloud.google.com/compute/docs/reference/rest/v1/backendServices)
- [Regional](https://cloud.google.com/compute/docs/reference/rest/v1/regionBackendServices)
For more information, seeBackend Services.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a minor formatting issue in the docstring. seeBackend should be see Backend to improve readability.

Suggested change
For more information, seeBackend Services.
For more information, see Backend Services.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting issue exists in the upstream proto. It needs to be fixed there:

image

https://raw.githubusercontent.com/googleapis/googleapis/refs/heads/master/google/cloud/compute/v1/compute.proto

Comment on lines +2083 to +2084
previously made from the disk. You must separatelydelete
snapshots.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a minor formatting issue in the docstring. separatelydelete should be separately delete to improve readability.

Suggested change
previously made from the disk. You must separatelydelete
snapshots.
previously made from the disk. You must separately delete
snapshots.

instances. For more information, read
Firewall rules.
instances. For more information,
readFirewall rules.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a minor formatting issue in the docstring. readFirewall should be read Firewall to improve readability.

Suggested change
readFirewall rules.
read Firewall rules.

Comment on lines +1549 to 1550
method supportsPATCH semantics and usesJSON merge
patch format and processing rules.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are minor formatting issues in the docstring. supportsPATCH should be supports PATCH and usesJSON should be uses JSON to improve readability.

Suggested change
method supportsPATCH semantics and usesJSON merge
patch format and processing rules.
method supports PATCH semantics and uses JSON merge patch
format and processing rules.

r"""Returns the latest image that is part of an image
family and is not deprecated. For more information on
image families, see Public image families documentation.
image families, seePublic image families documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a minor formatting issue in the docstring. seePublic should be see Public to improve readability.

Suggested change
image families, seePublic image families documentation.
image families, see Public image families documentation.

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 9, 2026
@parthea parthea enabled auto-merge (squash) January 9, 2026 15:04
@parthea parthea merged commit 63cc1cd into main Jan 9, 2026
26 of 27 checks passed
@parthea parthea deleted the librarian-20260108T222925Z branch January 9, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants