chore(deps): Update .NET version for .NET client smoke test ##633
Merged
chore(deps): Update .NET version for .NET client smoke test ##633
Conversation
product-auto-label
bot
added
the
api: eventarc
Contributor
Author
|
Would be great to get more feedback from @jskeet, but with a passing test I think it's worth moving forward with this change. |
Collaborator
|
Yup, this is the right fix - thanks for making it, and apologies for the inconvenience. (googleapis/google-cloudevents-dotnet#319 is where we changed to use .NET 8.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a .NET equivalent of a problem similar to #632. Depending on the order in which broken checks are resolved, this may also require an admin merge to bypass required checks.
According to the logs for a failing smoke test at https://github.com/googleapis/google-cloudevents/actions/runs/14789546588/job/41523929026,
I am not familiar with .NET runtimes but trying a naive update of the number to see what happens.