Skip to content

fix: add max_length support to Gzip/Brotli decoders for urllib3 v2.6+ compatibility #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benijaichenco wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add max_length support to Gzip/Brotli decoders for urllib3 v2.6+ compatibility #492

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b38722
fix: add max_length support to Gzip/Brotli decoders for urllib3 v2.6+…
benijaichenco Dec 7, 2025
c5a08f6
fix: add stream methods for urllib3 compatibility
benijaichenco Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions google/resumable_media/requests/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,17 +667,29 @@ def __init__(self, checksum):
super().__init__()
self._checksum = checksum

def decompress(self, data):
def decompress(self, data, max_length=-1):
"""Decompress the bytes.

Args:
data (bytes): The compressed bytes to be decompressed.
max_length (optional[int]): The maximum number of bytes to decompress.
This parameter is required for compatibility with urllib3>=2.6.0
and is passed to the underlying urllib3 decoder.

Returns:
bytes: The decompressed bytes from ``data``.
"""
self._checksum.update(data)
return super().decompress(data)
try:
return super().decompress(data, max_length=max_length)
except TypeError:
# FB for urllib3 <2.6.0
return super().decompress(data)

@property
def has_unconsumed_tail(self) -> bool:
# Checks for buffered, unread bytes
return self._decoder.has_unconsumed_tail
Comment on lines +689 to +692
Copy link

@chandra-siri chandra-siri Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this property is not required for _GzipDecoder . It's needed only for _BrotliDecoder.

Please remove these lines.



# urllib3.response.BrotliDecoder might not exist depending on whether brotli is
Expand All @@ -703,20 +715,32 @@ def __init__(self, checksum):
self._decoder = urllib3.response.BrotliDecoder()
self._checksum = checksum

def decompress(self, data):
def decompress(self, data, max_length=-1):
"""Decompress the bytes.

Args:
data (bytes): The compressed bytes to be decompressed.
max_length (optional[int]): The maximum number of bytes to decompress.
This parameter is required for compatibility with urllib3>=2.6.0
and is passed to the underlying urllib3 decoder.

Returns:
bytes: The decompressed bytes from ``data``.
"""
self._checksum.update(data)
return self._decoder.decompress(data)
try:
return self._decoder.decompress(data, max_length=max_length)
except TypeError:
# FB for urllib3 <2.6.0
return self._decoder.decompress(data)

def flush(self):
return self._decoder.flush()

@property
def has_unconsumed_tail(self) -> bool:
# Checks for buffered, unread bytes
return self._decoder.has_unconsumed_tail

else: # pragma: NO COVER
_BrotliDecoder = None # type: ignore # pragma: NO COVER
Loading