Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-cloud-bigquery-jdbc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.5.2</version>
<version>3.5.4</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, it's a best practice to manage plugin versions in the <properties> section. This centralizes version management, making future updates easier and ensuring consistency. For example, the maven-shade-plugin version is hardcoded in two different profiles.

I suggest defining a property for the maven-surefire-plugin version and using it here.

You can add this to the <properties> section at the top of the file:

<properties>
  ...
  <maven-surefire-plugin.version>3.5.4</maven-surefire-plugin.version>
</properties>

Then, you can use the property here.

Suggested change
<version>3.5.4</version>
<version>${maven-surefire-plugin.version}</version>

<configuration>
<skip>${skipSurefire}</skip>
</configuration>
Expand Down