Skip to content

Conversation

@logachev
Copy link
Contributor

Move Dockerfile & Makefile helping JDBC development.

All Makefile commands were validated and work as expected.

Simplified dependencies by removing all transient deps from pom.xml, so we only depend on BQ SDK, BQ Storage SDK & HttpClient.

@logachev logachev requested review from a team as code owners January 15, 2026 00:58
@logachev logachev requested a review from mrfaizal January 15, 2026 00:58
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jan 15, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @logachev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the development experience and maintainability of the JDBC module. It centralizes development-related scripts by moving the Dockerfile and Makefile into the module's directory. Concurrently, it drastically simplifies the project's dependency management by pruning many transitive dependencies from the pom.xml, retaining only the core BigQuery SDK components and HttpClient. This change aims to reduce complexity, potential conflicts, and streamline the build process.

Highlights

  • Helper Scripts Relocation: The Dockerfile and Makefile, which provide essential helper scripts for JDBC development, have been moved into the google-cloud-bigquery-jdbc directory for better organization.
  • Dependency Simplification: The pom.xml file has been significantly refactored to remove numerous transient dependencies. The project now explicitly depends only on the BigQuery SDK, BigQuery Storage SDK, and HttpClient, leading to a cleaner dependency tree.
  • New Build Automation: New build and development automation has been introduced via the added Dockerfile and Makefile, providing standardized commands for building, testing, packaging, and running in a containerized environment.
  • Git Ignore Updates: The .gitignore file has been updated to include new entries for JDBC-specific build artifacts and directories, ensuring a cleaner repository.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request moves helper scripts for JDBC development and simplifies dependencies. The changes are generally positive, but there are some areas for improvement. The new Dockerfile can be optimized for better layer caching and security. The Makefile introduces a significant security risk by handling credentials insecurely. Additionally, the dependency simplification in the pom.xml is good, but there's a small redundancy that can be cleaned up. My review includes specific suggestions to address these points.

<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-bigquery</artifactId>
<version>2.57.2-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigquery:current} -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version for the google-cloud-bigquery dependency is explicitly defined here. However, this version is already managed by the parent POM (google-cloud-bigquery-parent). To improve maintainability and rely on the centralized dependency management from the parent, this <version> tag should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant