Skip to content

Conversation

@logachev
Copy link
Contributor

@logachev logachev commented Jan 16, 2026

  • Adding JDBC to the parent pom.xml
  • Excluding JDBC project from integration/graal-vm Kokoro runs
  • Add 2 new cloudbuilds: presubmit & nightly
  • Update versions.txt to contain jdbc version

Note: for now I also enabled ignoring "used but undeclared dependencies". I'm not sure what's the right path given that those dependencies are entirely due to BQ/BQ-Storage dependencies. Not sure if duplicating the list makes a lot of sense

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jan 16, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @logachev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a build configuration update to formally include the google-cloud-bigquery-jdbc module within the main project's Maven build structure. This integration is a necessary step to facilitate the setup of presubmit checks for the JDBC module, ensuring its code quality and stability are maintained through automated testing.

Highlights

  • Build Configuration Update: The google-cloud-bigquery-jdbc module has been explicitly added to the project's pom.xml as a build module. This change is foundational for enabling presubmit checks and ensuring the module is properly integrated into the continuous integration pipeline.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates the google-cloud-bigquery-jdbc module into the project's build by adding it to the root pom.xml. This change correctly includes the JDBC module in the Maven reactor build, which will ensure it is covered by presubmit checks. The changes are straightforward and appropriate for the stated goal. No issues were found.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Jan 16, 2026
@logachev logachev force-pushed the kirl/jdbc_presubmit branch 2 times, most recently from 830319b to b221b3a Compare January 16, 2026 20:55
@logachev logachev force-pushed the kirl/jdbc_presubmit branch from b221b3a to 6eec093 Compare January 16, 2026 21:14
@logachev logachev force-pushed the kirl/jdbc_presubmit branch from 3eff43b to d5e799e Compare January 16, 2026 22:01
@logachev logachev marked this pull request as ready for review January 16, 2026 22:16
@logachev logachev requested review from a team as code owners January 16, 2026 22:16
@logachev logachev requested a review from chalmerlowe January 16, 2026 22:16
@logachev logachev changed the title chore(jdbc): integrate presubmits chore(jdbc): JDBC presubmit & nightly pipelines Jan 16, 2026
@logachev
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces presubmit and nightly build pipelines for the JDBC module, along with necessary adjustments to the build scripts and POM files. The changes are generally well-structured. However, I've identified a configuration issue in the pom.xml for handling undeclared dependencies and a potential syntax error in the build.sh script. Addressing these points will improve the robustness of the new build configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant