-
Notifications
You must be signed in to change notification settings - Fork 130
chore(jdbc): JDBC presubmit & nightly pipelines #4066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @logachev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a build configuration update to formally include the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request integrates the google-cloud-bigquery-jdbc module into the project's build by adding it to the root pom.xml. This change correctly includes the JDBC module in the Maven reactor build, which will ensure it is covered by presubmit checks. The changes are straightforward and appropriate for the stated goal. No issues were found.
830319b to
b221b3a
Compare
b221b3a to
6eec093
Compare
3eff43b to
d5e799e
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces presubmit and nightly build pipelines for the JDBC module, along with necessary adjustments to the build scripts and POM files. The changes are generally well-structured. However, I've identified a configuration issue in the pom.xml for handling undeclared dependencies and a potential syntax error in the build.sh script. Addressing these points will improve the robustness of the new build configurations.
Note: for now I also enabled ignoring "used but undeclared dependencies". I'm not sure what's the right path given that those dependencies are entirely due to BQ/BQ-Storage dependencies. Not sure if duplicating the list makes a lot of sense