Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Jan 16, 2026

Fixes: #4067

@lqiu96 lqiu96 requested a review from jinseopkim0 January 16, 2026 17:53
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jan 16, 2026
@lqiu96 lqiu96 marked this pull request as ready for review January 16, 2026 17:53
@lqiu96 lqiu96 requested review from a team as code owners January 16, 2026 17:53
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lqiu96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a known flakiness issue in an integration test designed to verify the listing of BigQuery tables with time partitioning. The modifications enhance the test's reliability by ensuring it accurately locates and validates the specific table created during the test execution, thereby preventing intermittent failures.

Highlights

  • Flaky Test Fix: Addresses the flakiness in the testListTablesWithPartitioning integration test by refining its logic.
  • Test Logic Refinement: Improves the test's robustness by explicitly identifying the created partitioned table and validating its properties, including adding assertNotNull checks for TimePartitioning and ExpirationMs.
  • Constant Removal: Replaces a static EXPIRATION_MS constant with local variables within the test method for better isolation and clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a flaky test, testListTablesWithPartitioning, by making the test logic more robust. The changes involve identifying the test-created table more specifically by its name, which prevents interference from other concurrent tests. Additionally, the test now includes more explicit assertions to prevent NullPointerExceptions and fails faster on unexpected states. The use of a local variable for expiration time instead of a shared constant also improves test isolation. I've found a minor typo in a variable name and suggested a fix.

@lqiu96 lqiu96 merged commit a8aef5a into main Jan 16, 2026
25 checks passed
@lqiu96 lqiu96 deleted the disable-flaky-test branch January 16, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bigquery.it.ITNightlyBigQueryTest: testListTablesWithPartitioning failed

2 participants