fix(bigtable): add handling for gauge metrics #2719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
sushanb
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sushanb
force-pushed
the
sushanb_1
branch
2 times, most recently
from
d21e526 to
c59bfb6
Compare
mutianf
reviewed
Nov 25, 2025
| Timestamp endTimestamp = Timestamps.fromNanos(pointData.getEpochNanos()); | ||
| Timestamp startTimestamp; | ||
|
|
||
| if (kind == GAUGE) { |
Contributor
There was a problem hiding this comment.
nit: can we extract this to a helper method? handleGaugeMetric() or somehing
Contributor
Author
There was a problem hiding this comment.
FYI, this won't remain very long in 2 versions as we will move all metrics to cloud.BigtableClient schema. so let's put it here for now temporarily.
mutianf
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field points[0].interval.start_time had an invalid value of "2025-11-25T11:10:06.164418-08:00": The start time must be equal to the end time (2025-11-25T11:11:06.164633-08:00) for the gauge metric 'bigtable.googleapis.com/internal/client/grpc/subchannel/open_connections'