[feat] ppl #1770
Open
[feat] ppl #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup nix for idx
…uandy/PipelineResult
pipeline result
# Conflicts: # README.md # google-cloud-firestore/pom.xml # google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java # google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java # proto-google-cloud-firestore-v1/src/main/java/com/google/firestore/v1/DocumentProto.java
…vaPplPP # Conflicts: # README.md
wu-hui
commented
Sep 16, 2024
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java
Outdated
Show resolved
Hide resolved
| * }</pre> | ||
| */ | ||
| @BetaApi | ||
| public final class Pipeline { |
There was a problem hiding this comment.
Thanks, that PR looks very helpful.
| } | ||
| if (response.getResultsCount() > 0) { | ||
| numDocuments += response.getResultsCount(); | ||
| if (numDocuments % 100 == 0) { |
There was a problem hiding this comment.
Yeah, copy/paste from query does not work for pipeline here.
...-cloud-firestore/src/main/java/com/google/cloud/firestore/pipeline/expressions/Constant.java
Outdated
Show resolved
Hide resolved
| * @return A new {@code Expr} representing the addition operation. | ||
| */ | ||
| @BetaApi | ||
| default Add add(Object other) { |
There was a problem hiding this comment.
I don't think this is a problem. Constant.of should take care of the type inspection?
...-cloud-firestore/src/main/java/com/google/cloud/firestore/pipeline/expressions/Function.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/pipeline/stages/Stage.java
Show resolved
Hide resolved
# Conflicts: # google-cloud-firestore/src/main/java/com/google/cloud/firestore/Pipeline.java
* Implement new stages. * Replace toList() with older languages feature. * Pretty * Pretty * Comment out under development API surface * Pretty
* Refactor pipelines * Pretty * Simplify
* Refactor * Cleanup
* Incomplete prototyping of pipeline options * Incomplete prototyping of pipeline options * Incomplete prototyping of pipeline options * Incomplete prototyping of pipeline options * Changes from feedback * Expand example and fix. * Comments --------- Co-authored-by: wu-hui <[email protected]>
wu-hui
force-pushed
the
wuandy/JavaPplPP
branch
from
9b73345 to
d57f777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.