Skip to content

Commit 7fac879

Browse files
authored
chore: cleanup MyBatis sample for GoogleSQL (#2029)
1 parent 3476106 commit 7fac879

File tree

2 files changed

+7
-18
lines changed

2 files changed

+7
-18
lines changed

samples/spring-data-mybatis/googlesql/pom.xml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,13 @@
3232
<scope>import</scope>
3333
<type>pom</type>
3434
</dependency>
35+
<dependency>
36+
<groupId>com.google.cloud</groupId>
37+
<artifactId>google-cloud-spanner-bom</artifactId>
38+
<version>6.91.1</version>
39+
<scope>import</scope>
40+
<type>pom</type>
41+
</dependency>
3542
<dependency>
3643
<groupId>com.google.cloud</groupId>
3744
<artifactId>libraries-bom</artifactId>
@@ -62,16 +69,9 @@
6269
</dependency>
6370

6471
<!-- Add the Spanner JDBC driver. -->
65-
<!-- TODO: Remove the explicit versions when we have a new BOM release. -->
66-
<dependency>
67-
<groupId>com.google.cloud</groupId>
68-
<artifactId>google-cloud-spanner</artifactId>
69-
<version>6.91.1</version>
70-
</dependency>
7172
<dependency>
7273
<groupId>com.google.cloud</groupId>
7374
<artifactId>google-cloud-spanner-jdbc</artifactId>
74-
<version>2.29.1</version>
7575
<exclusions>
7676
<exclusion>
7777
<groupId>com.google.api.grpc</groupId>

samples/spring-data-mybatis/googlesql/src/test/java/com/google/cloud/spanner/sample/ApplicationTest.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -850,17 +850,6 @@ public void testRunApplication() {
850850
System.setProperty("spanner.additional_properties", "usePlainText=true");
851851
Application.main(new String[] {});
852852

853-
assertEquals(
854-
39,
855-
mockSpanner.getRequestsOfType(ExecuteSqlRequest.class).stream()
856-
.filter(
857-
request ->
858-
!request.getSql().equals("SELECT 1")
859-
&& !request
860-
.getSql()
861-
.equals(
862-
"SELECT * FROM singers ORDER BY sha256(last_name::bytea) LIMIT 1"))
863-
.count());
864853
assertEquals(3, mockSpanner.countRequestsOfType(ExecuteBatchDmlRequest.class));
865854
assertEquals(6, mockSpanner.countRequestsOfType(CommitRequest.class));
866855

0 commit comments

Comments
 (0)