Skip to content

Conversation

@Noremac201
Copy link
Contributor

Without this, users may believe that the supported set of connection properties is exhaustive in the README. In addition there could be lead-time between new features being added and the JDBC itself.

It should be noted that the version linked is main branch rather than the one actively used by the JDBC driver.

Fixes #1851

@Noremac201 Noremac201 requested review from a team as code owners December 5, 2024 22:45
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Dec 5, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Dec 5, 2024
Without this, users may believe that the supported set of connection
properties is exhaustive in the README. In addition there could be
lead-time between new features being added and the JDBC itself.

It should be noted that the version linked is `main` branch rather than
the one actively used by the JDBC driver.
@Noremac201 Noremac201 changed the title Add link in README for all supported ConnectionProperties Update README to include all supported ConnectionProperties Dec 5, 2024
@olavloite olavloite changed the title Update README to include all supported ConnectionProperties docs: update README to include all supported ConnectionProperties Dec 13, 2024
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2024
@olavloite olavloite merged commit 57ff472 into googleapis:main Dec 13, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] README's connection properties docs are not exhaustive

3 participants