Skip to content

fix: cast double Inf and NaN to float #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2025
Merged

fix: cast double Inf and NaN to float #2304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/google/cloud/spanner/jdbc/AbstractJdbcWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ static int checkedCastToInt(BigInteger val) throws SQLException {

/** Cast value and throw {@link SQLException} if out-of-range. */
static float checkedCastToFloat(double val) throws SQLException {
if (val > Float.MAX_VALUE || val < -Float.MAX_VALUE) {
if (Double.isFinite(val) && (val > Float.MAX_VALUE || val < -Float.MAX_VALUE)) {
throw JdbcSqlExceptionFactory.of(
String.format(OUT_OF_RANGE_MSG, "float", val), com.google.rpc.Code.OUT_OF_RANGE);
}
Expand Down
12 changes: 11 additions & 1 deletion src/test/java/com/google/cloud/spanner/jdbc/AbstractJdbcWrapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ public void testCheckedCastFromBigIntegerToLong() {
}

@Test
public void testCheckedCastToFloat() {
public void testCheckedCastToFloat() throws SQLException {
final CheckedCastChecker<Double> checker =
new CheckedCastChecker<>(AbstractJdbcWrapper::checkedCastToFloat);
assertThat(checker.cast(0D)).isTrue();
Expand All @@ -268,6 +268,16 @@ public void testCheckedCastToFloat() {
assertThat(checker.cast((double) Float.MIN_VALUE)).isTrue();
assertThat(checker.cast(-Float.MAX_VALUE * 2d)).isFalse();
assertThat(checker.cast(-Double.MAX_VALUE)).isFalse();

assertEquals(
Float.POSITIVE_INFINITY,
AbstractJdbcWrapper.checkedCastToFloat(Double.POSITIVE_INFINITY),
0.0d);
assertEquals(
Float.NEGATIVE_INFINITY,
AbstractJdbcWrapper.checkedCastToFloat(Double.NEGATIVE_INFINITY),
0.0d);
assertEquals(Float.NaN, AbstractJdbcWrapper.checkedCastToFloat(Double.NaN), 0.0d);
}

@Test
Expand Down
Loading