Skip to content

chore: fix built in client metric data #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2024
Merged

chore: fix built in client metric data #3415

merged 1 commit into from
Oct 16, 2024

Conversation

@surbhigarg92
Copy link
Contributor

@surbhigarg92 surbhigarg92 commented Oct 16, 2024

This PR fixes the below issues for client metrics.

  • Use correct project id instead of defaultProjectId
  • Sets a default value for directpath_enabled attribute
  • Use map overload for addAttributes in compositeTracer

@surbhigarg92 surbhigarg92 requested a review from a team as a code owner October 16, 2024 16:47
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Oct 16, 2024
@surbhigarg92 surbhigarg92 mentioned this pull request Oct 16, 2024
Merged
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 16, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1e8b82c into googleapis:main Oct 16, 2024
31 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 16, 2024
@surbhigarg92 surbhigarg92 deleted the client_metrics_fix branch November 1, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

@olavloite olavloite Awaiting requested review from olavloite

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@surbhigarg92 @rahul2393