Skip to content

chore(spanner): revert Avoid blocking thread in AsyncResultSet #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore(spanner): revert Avoid blocking thread in AsyncResultSet #3465

wants to merge 1 commit into from

Conversation

@rahul2393
Copy link
Contributor

@rahul2393 rahul2393 commented Nov 11, 2024

This reverts commit 7c82f1c.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@rahul2393 rahul2393 requested a review from a team as a code owner November 11, 2024 13:10
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. labels Nov 11, 2024
@rahul2393 rahul2393 changed the title Revert "fix(spanner): Avoid blocking thread in AsyncResultSet (#3446)" chore(spanner): Avoid blocking thread in AsyncResultSet (#3446) Nov 11, 2024
@rahul2393 rahul2393 changed the title chore(spanner): Avoid blocking thread in AsyncResultSet (#3446) chore(spanner): revert Avoid blocking thread in AsyncResultSet Nov 11, 2024
@rahul2393 rahul2393 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 12, 2024
@rahul2393 rahul2393 closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sakthivelmanii sakthivelmanii sakthivelmanii approved these changes

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rahul2393 @sakthivelmanii