Skip to content

Conversation

@sakthivelmanii
Copy link
Collaborator

@sakthivelmanii sakthivelmanii commented Dec 9, 2024

Updates the version of maven-checkstyle-plugin and flatten-maven-plugin to versions that are available in Airlock (or that will be available in Airlock?)

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Dec 9, 2024
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/dependencies.sh
  • .kokoro/presubmit/dependencies.cfg

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Dec 9, 2024
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch from aa27d83 to 5cf2b81 Compare December 9, 2024 16:20
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Dec 10, 2024
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch 4 times, most recently from f8d97a4 to 73063ec Compare December 13, 2024 06:57
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 13, 2024
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch 2 times, most recently from a34779f to 306e023 Compare December 17, 2024 16:05
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch from 306e023 to f09a1f2 Compare December 24, 2024 04:52
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch 3 times, most recently from 9cc135e to 5772f63 Compare January 8, 2025 06:40
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch 3 times, most recently from de553ab to be34e92 Compare January 27, 2025 11:38
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jan 27, 2025
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch 7 times, most recently from 34855f5 to b164f74 Compare February 3, 2025 05:55
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 3, 2025
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch from 03de732 to 6d2d03c Compare February 3, 2025 07:22
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Feb 3, 2025
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch 2 times, most recently from e33d9ec to c68a3e1 Compare February 6, 2025 01:39
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Feb 6, 2025
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch 3 times, most recently from 2193a9e to 306ed90 Compare February 6, 2025 16:02
@sakthivelmanii sakthivelmanii marked this pull request as ready for review February 6, 2025 16:03
@sakthivelmanii sakthivelmanii requested review from a team as code owners February 6, 2025 16:03
@sakthivelmanii
Copy link
Collaborator Author

Build with Airlock will still fail because of sdk-platform-java

@sakthivelmanii sakthivelmanii changed the title ci(spanner): use airlock for fetching dependencies ci(spanner): Upgrade dependencies which are missing in Airlock Feb 6, 2025
@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch from 306ed90 to 64011bf Compare February 6, 2025 16:11
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the flatten plugin version is only need to be declared once at the root pom.xml

@sakthivelmanii
Copy link
Collaborator Author

it's used in all the submodule except one. probably that's why it's included in each module separately. I will take an AI to move it to root pom.xml

@sakthivelmanii sakthivelmanii force-pushed the use-airlock-for-fetching-dependencies branch from 64011bf to b8b9486 Compare February 26, 2025 04:16
@olavloite olavloite closed this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants