Skip to content

ci(spanner): Fix nightly samples job failure for creating managed autoscalar instance #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

ci(spanner): Fix nightly samples job failure for creating managed autoscalar instance #3627

merged 1 commit into from
Feb 10, 2025

Conversation

@sakthivelmanii
Copy link
Collaborator

@sakthivelmanii sakthivelmanii commented Feb 6, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sakthivelmanii sakthivelmanii requested review from a team as code owners February 6, 2025 13:15
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Feb 6, 2025
@sakthivelmanii sakthivelmanii force-pushed the update_spanner_edition_to_enterprise branch from 2ba014d to c501582 Compare February 6, 2025 13:20
@sakthivelmanii sakthivelmanii added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Feb 7, 2025
@sakthivelmanii sakthivelmanii force-pushed the update_spanner_edition_to_enterprise branch 2 times, most recently from fb77c96 to c501582 Compare February 7, 2025 10:39
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Feb 7, 2025
@sakthivelmanii sakthivelmanii force-pushed the update_spanner_edition_to_enterprise branch from 7399c00 to c501582 Compare February 10, 2025 17:40
@sakthivelmanii sakthivelmanii merged commit 32190d7 into main Feb 10, 2025
83 of 85 checks passed
@sakthivelmanii sakthivelmanii deleted the update_spanner_edition_to_enterprise branch February 10, 2025 18:50
@suztomo suztomo mentioned this pull request Mar 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshachinta harshachinta harshachinta approved these changes

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sakthivelmanii @harshachinta @kweinmeister @yoshi-kokoro