Skip to content

chore: enable multplexed sessions for experimental host #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 11, 2025
Merged

chore: enable multplexed sessions for experimental host #3676

merged 7 commits into from
Mar 11, 2025

Conversation

@sagnghos
Copy link
Contributor

@sagnghos sagnghos commented Mar 5, 2025

Ensure multiplexed sessions are used when client is connecting to an experimental host

@sagnghos sagnghos requested review from a team as code owners March 5, 2025 08:46
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 5, 2025
olavloite
olavloite reviewed Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test using the mock Spanner server for this option, and also include a test case that covers the situation that this new field tries to fix? (My understanding is that the need for a separate field was that only setting the various use-mux-sessions to true was not enough to prevent the BatchCreateSessions RPC to be called. This PR does not really do anything other than setting those three fields to true, which makes me believe that this change does not really fix the original problem. Or am I missing something here?

@sagnghos
Copy link
Contributor Author

sagnghos commented Mar 10, 2025

Can we add a test using the mock Spanner server for this option, and also include a test case that covers the situation that this new field tries to fix? (My understanding is that the need for a separate field was that only setting the various use-mux-sessions to true was not enough to prevent the BatchCreateSessions RPC to be called. This PR does not really do anything other than setting those three fields to true, which makes me believe that this change does not really fix the original problem. Or am I missing something here?

The code where its setting the minSessions and maxSessions to 0 is preventing the BatchCreateSessions rpc to be called.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 10, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 11, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 11, 2025
@olavloite olavloite merged commit 8367bfa into googleapis:main Mar 11, 2025
31 of 33 checks passed
@suztomo suztomo mentioned this pull request Mar 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olavloite olavloite olavloite approved these changes

+1 more reviewer

@krishnamoorthy-r krishnamoorthy-r krishnamoorthy-r left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sagnghos @olavloite @krishnamoorthy-r @yoshi-kokoro