Skip to content

Conversation

@olavloite
Copy link
Collaborator

Adds a global timeout that is applied to each of the tests in StatementTimeoutTest. This ensures that if any of the tests are slow, the test case will fail.

Also cleans up some warnings and removes some old-style assertions.

Adds a global timeout that is applied to each of the tests in
StatementTimeoutTest. This ensures that if any of the tests are slow,
the test case will fail.

Also cleans up some warnings and removes some old-style assertions.
@olavloite olavloite requested review from a team as code owners March 13, 2025 10:31
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 13, 2025
@olavloite olavloite merged commit 1b70be0 into main Mar 17, 2025
34 of 35 checks passed
@olavloite olavloite deleted the fail-statement-timeout-test-if-slow branch March 17, 2025 09:14
@suztomo suztomo mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants