Skip to content

test: cleanup AsyncResultSetImplTest#3696

Merged
olavloite merged 1 commit intomainfrom
cleanup-async-result-set-impl-test
Mar 18, 2025
Merged

test: cleanup AsyncResultSetImplTest#3696
olavloite merged 1 commit intomainfrom
cleanup-async-result-set-impl-test

Conversation

@olavloite
Copy link
Collaborator

Cleans up some warnings and a leaked thread that was not stopped in one of the tests. The actual flaky test was probably fixed as part of the refactor of async queries, and is no longer reproducible.

Closes #3365

Cleans up some warnings and a leaked thread that was not stopped in one
of the tests. The actual flaky test was probably fixed as part of the
refactor of async queries, and is no longer reproducible.

Closes #3365
@olavloite olavloite requested review from a team and sakthivelmanii March 18, 2025 15:40
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 18, 2025
@olavloite olavloite merged commit 23c6449 into main Mar 18, 2025
34 of 35 checks passed
@olavloite olavloite deleted the cleanup-async-result-set-impl-test branch March 18, 2025 17:39
@suztomo suztomo mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AsyncResultSetImplTest.testCallbackIsNotCalledWhilePausedAndCanceled is flaky

2 participants