Skip to content

test: unflake InlineBeginTransactionWithoutExecutorTest #3699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

test: unflake InlineBeginTransactionWithoutExecutorTest #3699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
329 changes: 170 additions & 159 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/InlineBeginTransactionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1668,192 +1668,203 @@ public void testWaitForTransactionTimeoutForCommit() {
assertEquals(0, countRequests(CommitRequest.class));
}

static void runWithIgnoreInlineBegin(Runnable runnable) {
// This will cause statements that requests a transaction to not return a transaction id.
mockSpanner.setIgnoreInlineBeginRequest(true);
try {
runnable.run();
} finally {
mockSpanner.setIgnoreInlineBeginRequest(false);
}
}

@Test
public void testQueryWithInlineBeginDidNotReturnTransaction() {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
// This will cause the first statement that requests a transaction to not return a transaction
// id.
mockSpanner.ignoreNextInlineBeginRequest();
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction -> {
try (ResultSet rs =
transaction.executeQuery(SELECT1_UNION_ALL_SELECT2)) {
while (rs.next()) {}
}
return null;
}));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteSqlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
runWithIgnoreInlineBegin(
() -> {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction -> {
try (ResultSet rs =
transaction.executeQuery(SELECT1_UNION_ALL_SELECT2)) {
while (rs.next()) {}
}
return null;
}));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteSqlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
});
}

@Test
public void testReadWithInlineBeginDidNotReturnTransaction() {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
// This will cause the first statement that requests a transaction to not return a transaction
// id.
mockSpanner.ignoreNextInlineBeginRequest();
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction ->
transaction.readRow(
"FOO", Key.of(1L), Collections.singletonList("BAR"))));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ReadRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
runWithIgnoreInlineBegin(
() -> {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction ->
transaction.readRow(
"FOO", Key.of(1L), Collections.singletonList("BAR"))));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ReadRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
});
}

@Test
public void testUpdateWithInlineBeginDidNotReturnTransaction() {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
// This will cause the first statement that requests a transaction to not return a transaction
// id.
mockSpanner.ignoreNextInlineBeginRequest();
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(transaction -> transaction.executeUpdate(UPDATE_STATEMENT)));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteSqlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
runWithIgnoreInlineBegin(
() -> {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(transaction -> transaction.executeUpdate(UPDATE_STATEMENT)));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteSqlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
});
}

@Test
public void testBatchUpdateWithInlineBeginDidNotReturnTransaction() {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
// This will cause the first statement that requests a transaction to not return a transaction
// id.
mockSpanner.ignoreNextInlineBeginRequest();
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction -> {
transaction.batchUpdate(Collections.singletonList(UPDATE_STATEMENT));
return null;
}));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteBatchDmlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
runWithIgnoreInlineBegin(
() -> {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction -> {
transaction.batchUpdate(
Collections.singletonList(UPDATE_STATEMENT));
return null;
}));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteBatchDmlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
});
}

@Test
public void testQueryAsyncWithInlineBeginDidNotReturnTransaction() {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
final ExecutorService executor = Executors.newSingleThreadExecutor();
// This will cause the first statement that requests a transaction to not return a transaction
// id.
mockSpanner.ignoreNextInlineBeginRequest();
SpannerException outerException =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction -> {
try (AsyncResultSet rs =
transaction.executeQueryAsync(SELECT1_UNION_ALL_SELECT2)) {
return SpannerApiFutures.get(
rs.setCallback(
executor,
resultSet -> {
try {
while (true) {
switch (resultSet.tryNext()) {
case OK:
break;
case DONE:
runWithIgnoreInlineBegin(
() -> {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
final ExecutorService executor = Executors.newSingleThreadExecutor();
SpannerException outerException =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction -> {
try (AsyncResultSet rs =
transaction.executeQueryAsync(SELECT1_UNION_ALL_SELECT2)) {
return SpannerApiFutures.get(
rs.setCallback(
executor,
resultSet -> {
try {
while (true) {
switch (resultSet.tryNext()) {
case OK:
break;
case DONE:
return CallbackResponse.DONE;
case NOT_READY:
return CallbackResponse.CONTINUE;
}
}
} catch (SpannerException e) {
return CallbackResponse.DONE;
case NOT_READY:
return CallbackResponse.CONTINUE;
}
}
} catch (SpannerException e) {
return CallbackResponse.DONE;
}
}));
}
}));
assertEquals(ErrorCode.FAILED_PRECONDITION, outerException.getErrorCode());
assertThat(outerException.getMessage())
.contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);

assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteSqlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
}
}));
}
}));
assertEquals(ErrorCode.FAILED_PRECONDITION, outerException.getErrorCode());
assertThat(outerException.getMessage())
.contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);

assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteSqlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
});
}

@Test
public void testUpdateAsyncWithInlineBeginDidNotReturnTransaction() {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
// This will cause the first statement that requests a transaction to not return a transaction
// id.
mockSpanner.ignoreNextInlineBeginRequest();
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction ->
SpannerApiFutures.get(
transaction.executeUpdateAsync(UPDATE_STATEMENT))));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteSqlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
runWithIgnoreInlineBegin(
() -> {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction ->
SpannerApiFutures.get(
transaction.executeUpdateAsync(UPDATE_STATEMENT))));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteSqlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
});
}

@Test
public void testBatchUpdateAsyncWithInlineBeginDidNotReturnTransaction() {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
// This will cause the first statement that requests a transaction to not return a transaction
// id.
mockSpanner.ignoreNextInlineBeginRequest();
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction ->
SpannerApiFutures.get(
transaction.batchUpdateAsync(
Collections.singletonList(UPDATE_STATEMENT)))));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteBatchDmlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
runWithIgnoreInlineBegin(
() -> {
DatabaseClient client = spanner.getDatabaseClient(DatabaseId.of("p", "i", "d"));
SpannerException e =
assertThrows(
SpannerException.class,
() ->
client
.readWriteTransaction()
.run(
transaction ->
SpannerApiFutures.get(
transaction.batchUpdateAsync(
Collections.singletonList(UPDATE_STATEMENT)))));
assertEquals(ErrorCode.FAILED_PRECONDITION, e.getErrorCode());
assertThat(e.getMessage()).contains(AbstractReadContext.NO_TRANSACTION_RETURNED_MSG);
assertThat(countRequests(BeginTransactionRequest.class)).isEqualTo(0);
assertThat(countRequests(ExecuteBatchDmlRequest.class)).isEqualTo(1);
assertThat(countRequests(CommitRequest.class)).isEqualTo(0);
});
}

@Test
Expand Down
Loading
Loading