Skip to content

fix: add default implementation for Interval methods in AbstractStructReader #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

fix: add default implementation for Interval methods in AbstractStructReader #3721

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
df6ebe7
Add support for Interval in Java Client
Oct 16, 2024
f16ae42
Merge branch 'googleapis:main' into interval_support
sagarwaal Oct 22, 2024
1e5f593
Added integration test for typed query parameter and fixed Interval p…
Oct 24, 2024
f9e6383
resolved cl comments
Nov 12, 2024
9873e90
Improved test coverage of Interval class
Nov 16, 2024
95c0b1b
API changes for Interval Class
Jan 1, 2025
4bb5721
Fix the values for duration constants
Mar 10, 2025
ba90228
Fix the values for duration constants
Mar 10, 2025
e8b918a
Merge branch 'main' into interval_support
sagarwaal Mar 12, 2025
100a43b
Merge branch 'main' into interval_support
sagarwaal Mar 18, 2025
4f2543a
Merge remote-tracking branch 'refs/remotes/origin/interval_support' i…
Mar 18, 2025
90c1478
fix formatting
Mar 18, 2025
15cbbdc
Run interval integration tests only against cloud-devel.
Mar 19, 2025
a877c11
Fixed casing of local variables
Mar 26, 2025
feceddf
addressed open comments
Mar 26, 2025
07012c1
removed dependency on jetbrains annotations
Mar 28, 2025
b5fa75c
provide default implementation for interval methods in AbstractStruct…
Apr 1, 2025
5ce8ee8
Merge remote-tracking branch 'upstream' into origin/interval_fix
Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ protected String getPgJsonbInternal(int columnIndex) {

protected abstract Date getDateInternal(int columnIndex);

protected abstract Interval getIntervalInternal(int columnIndex);
protected Interval getIntervalInternal(int columnIndex) {
throw new UnsupportedOperationException("Not implemented");
}

protected <T extends AbstractMessage> T getProtoMessageInternal(int columnIndex, T message) {
throw new UnsupportedOperationException("Not implemented");
Expand Down Expand Up @@ -130,7 +132,9 @@ protected List<String> getPgJsonbListInternal(int columnIndex) {

protected abstract List<Date> getDateListInternal(int columnIndex);

protected abstract List<Interval> getIntervalListInternal(int columnIndex);
protected List<Interval> getIntervalListInternal(int columnIndex) {
throw new UnsupportedOperationException("Not implemented");
}

protected abstract List<Struct> getStructListInternal(int columnIndex);

Expand Down
Loading