Skip to content

chore: update benchmarking script #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

chore: update benchmarking script #3882

merged 1 commit into from
May 20, 2025

Conversation

@sakthivelmanii
Copy link
Collaborator

Description:

Following features are added

  1. Support running benchmarking for specific time(30m)
  2. Support running warm up before running benchmarking
  3. Support staleness
  4. Support running reads

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sakthivelmanii sakthivelmanii requested review from a team as code owners May 19, 2025 12:00
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. labels May 19, 2025
rahul2393
rahul2393 reviewed May 20, 2025
View reviewed changes
rahul2393
rahul2393 reviewed May 20, 2025
View reviewed changes
benchmarks/src/main/java/com/google/cloud/spanner/benchmark/AbstractRunner.java
static final String TABLE_NAME = "Employees";
static final String SELECT_QUERY = String.format("SELECT ID FROM %s WHERE ID = @id", TABLE_NAME);
static final String UPDATE_QUERY =
String.format("UPDATE %s SET Name=Google WHERE ID = @id", TABLE_NAME);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Google here be in quotes?

@sakthivelmanii sakthivelmanii merged commit 1c93a3d into main May 20, 2025
49 of 51 checks passed
@sakthivelmanii sakthivelmanii deleted the update_benchmarking_script branch May 20, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sakthivelmanii @rahul2393