test: correctly return tx id for update counts #4045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mock Spanner server did not correctly return the transaction ID when ExecuteStreamingSql was used in combination with an update count result. Instead of returning the transaction ID of the transaction that was actually started, it returned the transaction ID that was set on the request. This would be empty for requests that used a Begin transaction selector, which again meant that it would return an empty transaction ID. This change also returns the UPDATE_COUNT field in the result set, which is also not returned by real Spanner.
product-auto-label
bot
added
size: s
rahul2393
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mock Spanner server did not correctly return the transaction ID when ExecuteStreamingSql was used in combination with an update count result.
Instead of returning the transaction ID of the transaction that was actually started, it returned the transaction ID that was set on the request. This would be empty for requests that used a Begin transaction selector, which again meant that it would return an empty transaction ID.
This change also returns the UPDATE_COUNT field in the result set, which is also not returned by real Spanner.