Skip to content

chore: disable afe latency metric test #4050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2025
Merged

chore: disable afe latency metric test #4050

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
616b34a
chore: disable afe latency metric test
surbhigarg92 Sep 16, 2025
ed2dd63
Merge branch 'main' into disable_afe_metric
surbhigarg92 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITBuiltInMetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,18 @@ public void testBuiltinMetricsWithDefaultOTEL() throws Exception {
response = metricClient.listTimeSeriesCallable().call(request);
}

assertWithMessage("Metric " + metric + " didn't return any data.")
.that(response.getTimeSeriesCount())
.isGreaterThan(0);
// afe_latencies metric currently does not return data as afe server-timing header is
// disabled.
// Keeping this check to enable this check in the future.
if (metric.equals("afe_latencies")) {
assertWithMessage("Metric " + metric + " returned data.")
.that(response.getTimeSeriesCount())
.isEqualTo(0);
} else {
assertWithMessage("Metric " + metric + " didn't return any data.")
.that(response.getTimeSeriesCount())
.isGreaterThan(0);
}
}
}
}
Loading