docs: add warning for encoded credential #4182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
This reverts commit b28885f.
…com/googleapis/java-spanner into indicate-unsafe-encoded-credentials
lqiu96
reviewed
Oct 22, 2025
Comment on lines
262
to
267
| "The location of the credentials file to use for this connection. If neither this" | ||
| + " property or encoded credentials are set, the connection will use the default" | ||
| + " Google Cloud credentials for the runtime environment.", | ||
| DEFAULT_CREDENTIALS, | ||
| StringValueConverter.INSTANCE, | ||
| Context.STARTUP); |
There was a problem hiding this comment.
I think we also need it here. This property eventually calls:
There was a problem hiding this comment.
Good point, thanks. I added a similar comment here.
|
LGTM, but Knut or Spanner team for final approval |
…com/googleapis/java-spanner into indicate-unsafe-encoded-credentials
product-auto-label
bot
added
size: s
rahul2393
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See b/437991832 for more context.