chore: remove session pool and only use multiplexed sessions #4191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the SessionPool and related classes and deprecates the SessionPoolOptions class. This simplifies large parts of the code, as the only possible code path is the use of multiplexed sessions.
product-auto-label
bot
added
size: xl
|
Warning: This pull request is touching the following templated files:
|
olavloite
force-pushed
the
remove-session-pool
branch
from
b89fd14 to
579abba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
SessionPooland related classes and deprecates theSessionPoolOptionsclass. This simplifies large parts of the code, as the only possible code path is the use of multiplexed sessions.After this change, the client does not create and initialize a session pool when it is created. This means that the number of sessions that is observed on Spanner will be much lower, as each
DatabaseClientonly creates 1 multiplexed session.