chore: Use AltContext to check DirectPath Used attribute #4221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
surbhigarg92
force-pushed
the
directpath_used_attr
branch
from
5c2f96c to
4f0779f
Compare
surbhigarg92
added
the
do not merge
| Boolean isDirectPathUsed = | ||
| isDirectPathUsed(getAttributes().get(Grpc.TRANSPORT_ATTR_REMOTE_ADDR)); | ||
| // Check if the call uses DirectPath by inspecting the ALTS context. | ||
| boolean isDirectPathUsed = AltsContextUtil.check(call); |
Collaborator
There was a problem hiding this comment.
You can call AltsContextUtil.check(getAttributes()). This will avoid storing clientcall object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic to check if RPC has used DirectPath or not. Noe Alts Information will be used to check if DP is used instead of relying on IP address range