feat: Add grpc.xds.resource_type label to xDS client metrics #4222
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
surbhigarg92
previously approved these changes
Nov 14, 2025
rahul2393
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
|
@HailongWen direct path tests are failing currently with below error Can you please help us to figure out what might be wrong, or add relevant folks here? |
Contributor
Author
The error seems unrelated to this PR. And manual tests do not run into this issue. Will look into that internally. |
rahul2393
approved these changes
Nov 14, 2025
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to add the missing grpc.xds.resource_type label in xds_client metrics (b/451687047).