Skip to content

deps: update dependency com.google.api.grpc:proto-google-cloud-trace-v1 to v2.80.0 #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

deps: update dependency com.google.api.grpc:proto-google-cloud-trace-v1 to v2.80.0 #4227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-cloud-spanner-executor/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-trace-v1</artifactId>
<version>2.79.0</version>
<version>2.80.0</version>
Copy link

@gemini-code-assist gemini-code-assist bot Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This version is also hardcoded in google-cloud-spanner/pom.xml. To improve maintainability and avoid inconsistencies, consider defining this version as a property in the parent pom.xml (google-cloud-spanner-parent) and referencing it in both modules. This would centralize the version management for this dependency, requiring only a single change for future updates.

For example, in the parent pom.xml, you could add a property:

<properties>
  ...
  <proto-google-cloud-trace.version>2.80.0</proto-google-cloud-trace.version>
</properties>

Then, in this file and google-cloud-spanner/pom.xml, you could use:

<version>${proto-google-cloud-trace.version}</version>

<!-- Version will be managed by guava -->
Comment on lines +147 to 148
Copy link

@gemini-code-assist gemini-code-assist bot Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version for proto-google-cloud-trace-v1 is hardcoded here and also in google-cloud-spanner/pom.xml. To improve maintainability and prevent potential version inconsistencies across modules, I recommend managing this dependency's version in the <dependencyManagement> section of the parent pom.xml. This would allow you to define the version in one place and remove the explicit <version> tag from the module POMs.

Additionally, the comment on line 148, <!-- Version will be managed by guava -->, appears to be outdated or incorrect since the version is explicitly set.

<exclusions>
<exclusion>
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-spanner/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-trace-v1</artifactId>
<version>2.79.0</version>
<version>2.80.0</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down