Skip to content

Conversation

@nidhiii-27
Copy link
Contributor

Added samples:
storage_get_encryption_enforcement_config
storage_remove_encryption_enforcement_config
storage_set_encryption_enforcement_config

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Oct 28, 2025
@nidhiii-27 nidhiii-27 marked this pull request as ready for review October 30, 2025 13:51
@snippet-bot
Copy link

snippet-bot bot commented Oct 30, 2025

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

.setCustomerSuppliedEncryptionEnforcementConfig(null)
.build();

storage.update(bucketInfo);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we repuspose this class to be more generic like to "Update" EncryptionEnforcementConfig instead?
This way may be we can have samples for :

  1. remove a specific encryption enforcement (maybe taking in encryption-type as input: gmek, cmek, csek)?
  2. remove all encryption enforcement all together.
  3. update a specific encryption types' restriction mode?
    wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we are already updating and doing this in the three different examples in SetBucketEncryptionEnforcementConfig
and if a specific case is needed, we can add it there

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't SetBucketEncryptionEnforcementConfig for "bucket create, along with encryption-enforcement config",
while UpdateBucketEncryptionEnforcementConfig would be for all kinds of "bucket update, related to encryption-enforcement config"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants