-
Notifications
You must be signed in to change notification settings - Fork 86
samples: add samples for encryption enforcement config feature #3369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
samples/snippets/src/main/java/com/example/storage/bucket/GetEncryptionEnforcementConfig.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/storage/bucket/GetEncryptionEnforcementConfig.java
Outdated
Show resolved
Hide resolved
.../snippets/src/main/java/com/example/storage/bucket/RemoveAllEncryptionEnforcementConfig.java
Show resolved
Hide resolved
| .setCustomerSuppliedEncryptionEnforcementConfig(null) | ||
| .build(); | ||
|
|
||
| storage.update(bucketInfo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we repuspose this class to be more generic like to "Update" EncryptionEnforcementConfig instead?
This way may be we can have samples for :
- remove a specific encryption enforcement (maybe taking in encryption-type as input: gmek, cmek, csek)?
- remove all encryption enforcement all together.
- update a specific encryption types' restriction mode?
wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we are already updating and doing this in the three different examples in SetBucketEncryptionEnforcementConfig
and if a specific case is needed, we can add it there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't SetBucketEncryptionEnforcementConfig for "bucket create, along with encryption-enforcement config",
while UpdateBucketEncryptionEnforcementConfig would be for all kinds of "bucket update, related to encryption-enforcement config"?
Added samples:
storage_get_encryption_enforcement_config
storage_remove_encryption_enforcement_config
storage_set_encryption_enforcement_config