fix: populate configure command pr content #2591

ohmayr · 2025-10-16T02:50:44Z

This PR includes the fix to correctly populate the PR title, body, and commit for configuring a new library.

gemini-code-assist · 2025-10-16T02:51:00Z

Summary of Changes

Hello @ohmayr, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the configure command was not accurately populating the commit message for pull requests related to onboarding new libraries. The changes ensure that the commit message correctly reflects whether a new library is being added or an existing one is being generated, thereby improving the clarity and precision of automatically generated PR content. Additionally, comprehensive test updates have been implemented to validate these commit message behaviors.

Highlights

Correct Commit Message for Onboarding: The system now correctly assigns the commit message 'feat: onboard a new library' when configuring a new library, differentiating it from the generic 'feat: generate libraries' used for existing library updates.
Accurate PR Type Identification: The generateSingleLibrary function has been updated to correctly set the prType to pullRequestOnboard when an initial library configuration is being performed, ensuring proper handling of new library setups.
Enhanced Test Coverage for Commit Messages: New test logic has been introduced in TestGenerateScenarios to utilize a MockRepository and assert the exact commit messages generated for both new library onboarding and existing library generation, improving reliability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

codecov · 2025-10-16T02:52:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.14%. Comparing base (16df43c) to head (850c6f8).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2591      +/-   ##
==========================================
+ Coverage   85.51%   86.14%   +0.62%     
==========================================
  Files         107      107              
  Lines       10798    11003     +205     
==========================================
+ Hits         9234     9478     +244     
+ Misses       1234     1206      -28     
+ Partials      330      319      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gemini-code-assist

Code Review

This pull request correctly adjusts the commit message and pull request type when onboarding a new library. The changes in generate_command.go are clear and address the issue. The test updates in generate_command_test.go successfully verify the new behavior. I've added a couple of suggestions to improve the test code's maintainability by reducing reliance on string matching test names and consolidating duplicated logic. Overall, this is a good fix.

internal/librarian/generate_command_test.go

suztomo · 2025-10-16T13:15:45Z

@JoeWang1127 PTAL

internal/librarian/generate_command.go

suztomo · 2025-10-16T18:25:34Z

@JoeWang1127 @codyoss (Probably not in this PR) I think it's convenient if the "configure" pull request title has the API name, when thinking about sometimes we need to finding the pull request for API in https://github.com/googleapis/google-cloud-python/pulls?q=is%3Apr+is%3Aclosed.

Librarian Version: v0.0.0-20251022154542-dd249212325d Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest <details><summary>librarian: 0.5.0</summary> ## [0.5.0](v0.4.0...v0.5.0) (2025-10-22) ### Features * speed up finding changed files in commits (#2645) ([1060946](10609465)) * Can config dart `export` (#2641) ([97eacd2](97eacd29)) * minor whitespace and doc changes to the Dart templates (#2636) ([b3ac7b4](b3ac7b42)) * only generate libraries with changed APIs (#2618) ([82171be](82171bed)) * make extra modules public (#2622) ([2c94a53](2c94a53f)) * skip a GitHub release for a library (#2612) ([6258f4d](6258f4d1)) * allow skipping semver checks for rust-publish (#2584) ([739ce0d](739ce0d5)) * add ability to open pull request as a draft (#2604) ([c1f0285](c1f02859)) * capture discovery revision (#2605) ([14a1483](14a14830)) * Add conditional instrumentation to gRPC clients (#2594) ([3cc63b2](3cc63b22)) * add update-image CLI command (#2580) ([90e0f6e](90e0f6e5)) * Generate more samples for oneof main setters. (#2592) ([c55f3ce](c55f3ceb)) * Add documentation for generated service constructors (#2575) ([6a4aead](6a4aeade)) * disable some clippy warnings (#2567) ([9f51084](9f510842)) * Generate setter samples for oneof fields. (#2573) ([8c2416a](8c2416ab)) * add default Rust features option (#2562) ([892f42b](892f42b7)) * Include a correct URL for issues (#2570) ([10493ed](10493ed9)) * add ability to find the latest docker image SHA (#2539) ([62e80f1](62e80f19)) * add ability to checkout a repo at a certain commit (#2555) ([23b8ffe](23b8ffea)) * add onboarding PR body (#2552) ([e32719c](e32719cd)) ### Bug Fixes * associate bulk change to individual libraries (#2626) ([dd24921](dd249212)) * Allow `unnecessary_import`s (#2642) ([88c4379](88c43794)) * resolve issue where onboarded library can't be released (#2632) ([b300a4e](b300a4ea)) * resolve issue where commits cannot be fetched for new library (#2631) ([45652c0](45652c03)) * address a typo in the Message.ServicePlaceholder docs (#2616) ([82fda96](82fda96b)) * bad version bump edits (#2613) ([9902b1d](9902b1d5)) * use templates for update-image PR body (#2602) ([7309cad](7309cadd)) * populate configure command pr content (#2591) ([811eb8e](811eb8e2)) * shrink release PR size when there are bulk changes (#2585) ([bcb914a](bcb914ac)) * Fixes several issues with oneof main setter samples (#2589) ([e4958d0](e4958d00)) * resolve broken link in PR body (#2579) ([098c1d2](098c1d24)) * Remove double sample code blocks (#2582) ([6b10456](6b104567)) * change commit package (#2571) ([45ee48f](45ee48f0)) * show chores in release notes (#2544) ([88b62cc](88b62ccb)) * avoid work duplication when finding changes (#2558) ([0adeeac](0adeeac6)) * mangled method names and doc links (#2565) ([895dac9](895dac94)) ### Reverts * show chores in release notes (#2601) ([7e6740f](7e6740ff)) </details>

fix: populate configure command pr content

75ccec3

ohmayr requested a review from a team as a code owner October 16, 2025 02:50

gemini-code-assist bot reviewed Oct 16, 2025

View reviewed changes

internal/librarian/generate_command_test.go Outdated Show resolved Hide resolved

internal/librarian/generate_command_test.go Outdated Show resolved Hide resolved

address PR feedback

e3c7b8e

JoeWang1127 requested changes Oct 16, 2025

View reviewed changes

internal/librarian/generate_command.go Outdated Show resolved Hide resolved

internal/librarian/generate_command.go Show resolved Hide resolved

ohmayr added 3 commits October 16, 2025 17:10

address PR feedback

646f29d

address PR feedback

89e479b

address PR feedback

850c6f8

JoeWang1127 approved these changes Oct 16, 2025

View reviewed changes

ohmayr merged commit 811eb8e into main Oct 16, 2025
8 checks passed

ohmayr deleted the fix-configure-pr-title-body-commit branch October 16, 2025 20:29

cloud-sdk-librarian-robot mentioned this pull request Oct 22, 2025

chore: librarian release pull request: 20251022T180958Z #2653

Merged

zhumin8 pushed a commit to zhumin8/librarian that referenced this pull request Nov 17, 2025

impl(storage-control): auto-populate request IDs (googleapis#2591)

273441e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: populate configure command pr content #2591

fix: populate configure command pr content #2591

Uh oh!

ohmayr commented Oct 16, 2025

Uh oh!

gemini-code-assist bot commented Oct 16, 2025

Uh oh!

codecov bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

suztomo commented Oct 16, 2025

Uh oh!

Uh oh!

Uh oh!

suztomo commented Oct 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: populate configure command pr content #2591

fix: populate configure command pr content #2591

Uh oh!

Conversation

ohmayr commented Oct 16, 2025

Uh oh!

gemini-code-assist bot commented Oct 16, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

codecov bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

suztomo commented Oct 16, 2025

Uh oh!

Uh oh!

Uh oh!

suztomo commented Oct 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 16, 2025 •

edited

Loading