Skip to content

chore: allow-list Spanner#4072

Merged
coryan merged 4 commits intogoogleapis:mainfrom
olavloite:allow-list-spanner
Feb 16, 2026
Merged

chore: allow-list Spanner#4072
coryan merged 4 commits intogoogleapis:mainfrom
olavloite:allow-list-spanner

Conversation

@olavloite
Copy link
Contributor

Add the Spanner data client to the allow-list.

Also fixes an error when generating the code for the Type proto of Spanner. This proto has a direct recursive field array_element_type. This is generated as a boxed field, but the to_proto / from_proto methods did not take this into account.

Add the Spanner data client to the allow-list.

Also fixes an error when generating the code for the Type proto of Spanner.
This proto has a direct recursive field `array_element_type`. This is generated
as a boxed field, but the to_proto / from_proto methods did not take this into
account.
@olavloite olavloite requested review from a team as code owners February 16, 2026 15:30
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the Spanner data client to the allow-list. It also introduces a fix for generating code for recursive proto fields in Rust, specifically for types like Spanner's Type proto. A new MapToBoxed flag is added to field annotations to detect when prost will box a field due to recursion, and the to_proto conversion logic in the templates is updated to handle this correctly. The accompanying test updates are thorough and validate the new logic. I have one suggestion to improve the clarity of the mapToBoxed helper function's visited map initialization.

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.93%. Comparing base (0a5722d) to head (f92a9b7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4072   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files          78       78           
  Lines        6516     6516           
=======================================
  Hits         5339     5339           
  Misses        832      832           
  Partials      345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but it would be nicer if we separated the allow list change from the sidekick changes. Do you mind doing so?

@olavloite
Copy link
Contributor Author

The code LGTM, but it would be nicer if we separated the allow list change from the sidekick changes. Do you mind doing so?

Sure, I'll split it into two changes.

@coryan coryan enabled auto-merge (squash) February 16, 2026 16:23
@coryan coryan merged commit 2b3750a into googleapis:main Feb 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants